Closed
Conversation
Signed-off-by: Peter Wielander <mittgfu@gmail.com>
|
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Contributor
🧪 E2E Test Results❌ Some tests failed Summary
❌ Failed Tests💻 Local Development (2 failed)astro-stable (2 failed):
🌍 Community Worlds (17 failed)mongodb (1 failed):
redis (1 failed):
starter (14 failed):
turso (1 failed):
Details by Category✅ ▲ Vercel Production
❌ 💻 Local Development
✅ 📦 Local Production
✅ 🐘 Local Postgres
✅ 🪟 Windows
❌ 🌍 Community Worlds
❌ Some E2E test jobs failed:
Check the workflow run for details.
Check the workflow run for details. |
Contributor
📊 Benchmark Results
workflow with no steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Nitro | Next.js (Turbopack) workflow with 1 step💻 Local Development
▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) | Express | Nitro workflow with 10 sequential steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Nitro | Next.js (Turbopack) Promise.all with 10 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Nitro | Next.js (Turbopack) Promise.all with 25 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Next.js (Turbopack) | Nitro Promise.race with 10 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) | Nitro | Express Promise.race with 25 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Nitro | Next.js (Turbopack) Stream Benchmarks (includes TTFB metrics)workflow with stream💻 Local Development
▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) | Nitro | Express SummaryFastest Framework by WorldWinner determined by most benchmark wins
Fastest World by FrameworkWinner determined by most benchmark wins
Column Definitions
Worlds:
|
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
| test.skip(); | ||
| return; | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
URL manipulation using .split('?')[0] pattern is fragile and breaks in edge cases without proper path handling
…ng, retry logic, or server health diagnostics, causing cryptic failures if the server becomes unavailable during navigation.
|
|
||
| // Navigate to run detail page | ||
| const baseUrl = webPage.url().split('?')[0]; | ||
| const runDetailUrl = `${baseUrl}run/${runId}`; |
Contributor
There was a problem hiding this comment.
Screenshot test uses fragile string-based URL construction instead of URL API
Contributor
📸 Web UI ScreenshotsScreenshots captured from the Web UI E2E tests.
💻 Local Backend
▲ Vercel Backend
|
Comment on lines
+81
to
+89
| env: { | ||
| ...process.env, | ||
| WORKFLOW_TARGET_WORLD: '', | ||
| WORKFLOW_VERCEL_ENV: '', | ||
| WORKFLOW_VERCEL_AUTH_TOKEN: '', | ||
| WORKFLOW_VERCEL_PROJECT: '', | ||
| WORKFLOW_VERCEL_TEAM: '', | ||
| WORKFLOW_LOCAL_DATA_DIR: '', | ||
| }, |
Contributor
There was a problem hiding this comment.
Suggested change
| env: { | |
| ...process.env, | |
| WORKFLOW_TARGET_WORLD: '', | |
| WORKFLOW_VERCEL_ENV: '', | |
| WORKFLOW_VERCEL_AUTH_TOKEN: '', | |
| WORKFLOW_VERCEL_PROJECT: '', | |
| WORKFLOW_VERCEL_TEAM: '', | |
| WORKFLOW_LOCAL_DATA_DIR: '', | |
| }, | |
| env: (() => { | |
| const env = { ...process.env }; | |
| delete env.WORKFLOW_TARGET_WORLD; | |
| delete env.WORKFLOW_VERCEL_ENV; | |
| delete env.WORKFLOW_VERCEL_AUTH_TOKEN; | |
| delete env.WORKFLOW_VERCEL_PROJECT; | |
| delete env.WORKFLOW_VERCEL_TEAM; | |
| delete env.WORKFLOW_LOCAL_DATA_DIR; | |
| return env; | |
| })(), |
Environment variables set to empty strings instead of being properly removed in Playwright config
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.