[tests] [world-vercel] Allow using proxy for preview environments#738
Closed
VaguelySerious wants to merge 12 commits intomainfrom
Closed
[tests] [world-vercel] Allow using proxy for preview environments#738VaguelySerious wants to merge 12 commits intomainfrom
VaguelySerious wants to merge 12 commits intomainfrom
Conversation
- Remove skipProxy option from APIConfig in world-vercel - Add workflowServerPath option that passes ?path= to the proxy - Update WORKFLOW_VERCEL_SKIP_PROXY env var to WORKFLOW_VERCEL_WORKFLOW_SERVER_PATH - Update tests.yml to use the new workflow server path parameter This allows tests running against a preview workflow-server deployment to also use the proxy by specifying the target server URL.
- Remove separate workflowServerPath option from APIConfig - Use baseUrl as the target workflow server URL - When using proxy (projectId + teamId), always use hardcoded proxy URL and pass baseUrl as ?path= parameter - Update tests.yml to use WORKFLOW_VERCEL_BACKEND_URL instead of WORKFLOW_VERCEL_WORKFLOW_SERVER_PATH
🦋 Changeset detectedLatest commit: 08d924d The changes in this PR will be included in the next version bump. This PR includes changesets to release 14 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
📊 Benchmark Results
workflow with no steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Nitro | Next.js (Turbopack) workflow with 1 step💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Express | Next.js (Turbopack) workflow with 10 sequential steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) | Nitro | Express Promise.all with 10 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) | Express | Nitro Promise.all with 25 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) | Nitro | Express Promise.race with 10 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) | Nitro | Express Promise.race with 25 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Next.js (Turbopack) | Express Stream Benchmarks (includes TTFB metrics)workflow with stream💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Next.js (Turbopack) | Express SummaryFastest Framework by WorldWinner determined by most benchmark wins
Fastest World by FrameworkWinner determined by most benchmark wins
Column Definitions
Worlds:
|
Contributor
🧪 E2E Test Results❌ Some tests failed Summary
❌ Failed Tests▲ Vercel Production (154 failed)astro (14 failed):
example (14 failed):
express (14 failed):
fastify (14 failed):
hono (14 failed):
nextjs-turbopack (14 failed):
nextjs-webpack (14 failed):
nitro (14 failed):
nuxt (14 failed):
sveltekit (14 failed):
vite (14 failed):
💻 Local Development (2 failed)sveltekit-stable (2 failed):
🌍 Community Worlds (17 failed)mongodb (1 failed):
redis (1 failed):
starter (14 failed):
turso (1 failed):
Details by Category❌ ▲ Vercel Production
❌ 💻 Local Development
✅ 📦 Local Production
✅ 🐘 Local Postgres
✅ 🪟 Windows
❌ 🌍 Community Worlds
❌ Some E2E test jobs failed:
Check the workflow run for details. |
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
Signed-off-by: Peter Wielander <mittgfu@gmail.com>
Signed-off-by: Peter Wielander <mittgfu@gmail.com>
Co-authored-by: vercel[bot] <35613825+vercel[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relies on https://github.com/vercel/api/pull/56575
The idea is that generally, we send requests to whatever
WORKFLOW_VERCEL_BACKEND_URLpoint to, unless teamId+projectId are defined explicitly, which happens only in o11y (CLI + web) when pointed to a remote environment. In this case, we alway send requests to the proxy URL, with a headerx-vercel-workflow-api-url: ${WORKFLOW_VERCEL_BACKEND_URL}.We can now also test preview queue environments by sending
x-vercel-vqs-api-urlheader, but that isn't hooked up yet.