Skip to content

[test] workflow-server PR #369 #1689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
workflow-devkit-release-bot wants to merge 2 commits into from
+14 −53
Closed

[test] workflow-server PR #369 #1689

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c7036d3
test: Update WORKFLOW_SERVER_URL_OVERRIDE to https://workflow-server-…
workflow-devkit-release-bot[bot] Apr 10, 2026
85aa36c
Revert "fix(world-vercel): include runId in streams.get() request URL…
TooTallNate Apr 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions .changeset/fix-stream-get-runid.md
View file
Open in desktop

This file was deleted.

41 changes: 0 additions & 41 deletions packages/world-vercel/src/streamer.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,47 +180,6 @@ vi.mock('./utils.js', () => ({
}),
}));

describe('streams.get', () => {
async function getStreamer() {
const { createStreamer } = await import('./streamer.js');
return createStreamer();
}

afterEach(() => {
vi.restoreAllMocks();
});

it('includes runId in the fetch URL', async () => {
const fetchSpy = vi
.spyOn(globalThis, 'fetch')
.mockImplementation(
async () => new Response(new ReadableStream(), { status: 200 })
);

const streamer = await getStreamer();
await streamer.streams.get('run-123', 'my-stream');

expect(fetchSpy).toHaveBeenCalledTimes(1);
const url = new URL(fetchSpy.mock.calls[0][0] as string);
expect(url.pathname).toBe('/v2/runs/run-123/stream/my-stream');
});

it('passes startIndex as a query parameter', async () => {
const fetchSpy = vi
.spyOn(globalThis, 'fetch')
.mockImplementation(
async () => new Response(new ReadableStream(), { status: 200 })
);

const streamer = await getStreamer();
await streamer.streams.get('run-123', 'my-stream', 5);

const url = new URL(fetchSpy.mock.calls[0][0] as string);
expect(url.pathname).toBe('/v2/runs/run-123/stream/my-stream');
expect(url.searchParams.get('startIndex')).toBe('5');
});
});

describe('writeMulti pagination', () => {
/**
* Decode length-prefixed multi-chunk body to count chunks per request.
Expand Down
19 changes: 13 additions & 6 deletions packages/world-vercel/src/streamer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,17 @@ export const MAX_CHUNKS_PER_REQUEST = 1000;
// (partial writes, long-lived reads), and duplex streams are incompatible
// with undici's experimental H2 support.

function getStreamUrl(name: string, runId: string, httpConfig: HttpConfig) {
return new URL(
`${httpConfig.baseUrl}/v2/runs/${encodeURIComponent(runId)}/stream/${encodeURIComponent(name)}`
);
function getStreamUrl(
name: string,
runId: string | undefined,
httpConfig: HttpConfig
) {
if (runId) {
return new URL(
`${httpConfig.baseUrl}/v2/runs/${encodeURIComponent(runId)}/stream/${encodeURIComponent(name)}`
);
}
return new URL(`${httpConfig.baseUrl}/v2/stream/${encodeURIComponent(name)}`);
}

/**
Expand Down Expand Up @@ -181,9 +188,9 @@ export function createStreamer(config?: APIConfig): Streamer {
}
},

async get(runId: string, name: string, startIndex?: number) {
async get(_runId: string, name: string, startIndex?: number) {
const httpConfig = await getHttpConfig(config);
const url = getStreamUrl(name, runId, httpConfig);
const url = getStreamUrl(name, undefined, httpConfig);
if (typeof startIndex === 'number') {
url.searchParams.set('startIndex', String(startIndex));
}
Expand Down
2 changes: 1 addition & 1 deletion packages/world-vercel/src/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ function httpLog(
*
* Example: 'https://workflow-server-git-branch-name.vercel.sh'
*/
const WORKFLOW_SERVER_URL_OVERRIDE = '';
const WORKFLOW_SERVER_URL_OVERRIDE = 'https://workflow-server-fwrh4abdx.vercel.sh';

export interface APIConfig {
token?: string;
Expand Down
Loading