feat(sandbox,vercel-sandbox): support timeout parameter when executing a command#212
Open
marc-vercel wants to merge 2 commits into
Open
feat(sandbox,vercel-sandbox): support timeout parameter when executing a command#212marc-vercel wants to merge 2 commits into
marc-vercel wants to merge 2 commits into
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When running a command in a sandbox you currently have to wrap the call yourself with an
AbortController+setTimeoutto enforce a deadline. This is verbose, easy to get wrong (forgotten clear, race withawait), and the killed process can leak resources on the sandbox side because the cancellation only happens client-side.Solution
SDK contract
runCommandaccepts a newtimeoutMsoption. It is only meaningful for non-detached calls — combining it withdetached: truethrows a synchronousTypeError.It's also exposed on the convenience overload:
CLI contract
sandbox execgets a--timeoutflag that accepts a duration string (e.g.30s,5m). It cannot be combined with--interactive.sandbox exec my-sandbox --timeout 30s -- python train.py