fix: handle missing entity fields from X syndication API#219
Open
7IBO wants to merge 1 commit into
Open
Conversation
The X syndication API omits `entities.hashtags`, `.user_mentions`, `.urls`, and `.symbols` when a tweet has none of those, instead of returning empty arrays. This causes `getEntities` to pass `undefined` to `addEntities`, which crashes with `TypeError: entities is not iterable` in the `for...of` loop. Add `?? []` fallback in `getEntities` and a default parameter value in `addEntities` to handle the missing fields gracefully. Fixes vercel#218
Contributor
|
@7IBO is attempting to deploy a commit to the Vercel Labs Team on Vercel. A member of the Team first needs to authorize it. |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The X syndication API omits
entities.hashtags,.user_mentions,.urls, and.symbolswhen a tweet has none of those entities, instead of returning empty arrays. This causesgetEntities()to passundefinedtoaddEntities(), which crashes with:This affects any tweet that has no hashtags, mentions, URLs, or symbols (e.g. text + image only tweets).
Example tweet that reproduces the issue: https://x.com/RiotPhroxzon/status/2056998824779079835
Response from the syndication API for this tweet:
Note the absence of
hashtags,user_mentions,urls, andsymbolsfields.Fix
?? []fallback when passing entity arrays toaddEntities()ingetEntities()entities: TweetEntity[] = []inaddEntities()as an additional safety netFixes #218