[turbopack] Surface NUL-byte env var in Node.js pool spawn error - #97281
Open
AmatyaJoshi wants to merge 1 commit into
Open
[turbopack] Surface NUL-byte env var in Node.js pool spawn error#97281AmatyaJoshi wants to merge 1 commit into
AmatyaJoshi wants to merge 1 commit into
Conversation
When Turbopack spawns a pooled Node.js subprocess with an environment variable whose name or value contains a NUL byte, `Command::spawn` fails with only "nul byte found in provided data". The surrounding transform pipeline (e.g. PostCSS on globals.css) then attributes the failure to the module being processed, hiding the real cause. Validate env entries before spawning and bail with a message that names the offending variable and shows its value, matching webpack's behavior. Fixes vercel#97265 Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When Turbopack spawns a pooled Node.js subprocess with an environment variable whose name or value contains a NUL byte,
Command::spawnfails with only "nul byte found in provided data". The surrounding transform pipeline (e.g. PostCSS on globals.css) then attributes the failure to the module being processed, hiding the real cause.Validate env entries before spawning and bail with a message that names the offending variable and shows its value, matching webpack's behavior.
Fixes #97265