Remove HmrTarget - #97253
Open
wbinnssmith wants to merge 1 commit into
Open
Conversation
`HmrTarget` was only ever passed one value per call site. The aggregate path (`all_hmr_version_state`, `all_hmr_update`, `aggregate_hmr_root_path`) bailed on `Client`; every other HMR entry point passed `Client`. Drop the parameter and name the target in the method instead: - `all_hmr_*` -> `server_hmr_*` - `aggregate_hmr_root_path` -> `server_hmr_root_path` - `project_hmr_events` -> `project_client_hmr_events` - `project_hmr_chunk_names_subscribe` -> `project_client_hmr_chunk_names_subscribe` - `hmrEvents`/`allHmrEvents`/`hmrChunkNamesSubscribe` -> `clientHmrEvents`/`serverHmrEvents`/`clientHmrChunkNamesSubscribe` `hmr_root_path` collapses into `client_relative_path()` at its one remaining caller, and the `hmrEvents` overload pair goes away with it. No behavior change.
Contributor
Stats from current PRWarning No stats were collected for Webpack because its stats job did not complete (it failed, was cancelled, or timed out). The results below only cover the bundlers that finished. ✅ No significant changes detected📊 All Metrics📖 Metrics GlossaryDev Server Metrics:
Build Metrics:
Change Thresholds:
⚡ Dev Server
⚡ Production Builds
📦 Production Builds (Webpack) (Legacy)📦 Production Builds (Webpack)
📦 Bundle SizesBundle Sizes⚡ TurbopackClient Main Bundles
Server Middleware
Build DetailsBuild Manifests
Build Cache
🔄 Shared (bundler-independent)Runtimes
📝 Changed Files (2 files)Files with changes:
View diffspages-api.ru..time.prod.jsDiff too large to display pages.runtime.prod.jsDiff too large to display 📎 Tarball URLCommit: 06403e1 |
Contributor
Tests PassedCommit: 06403e1 |
wbinnssmith
marked this pull request as ready for review
August 12, 2026 17:58
wbinnssmith
requested review from
bgw and
lukesandberg
and removed request for
bgw
August 12, 2026 18:15
lukesandberg
approved these changes
Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With #94948 we intended to move the client over to the firehose feed of HMR events with the intent of unifying the code paths for maintenance. However, now that Server HMR is moving to a pull-based model (which client HMR will not be able to implement), let's keep the split.
There's no need to encode the HmrTarget into each surface, and we can just use the function name to indicate which mode of HMR it's for.