perf(parse): resolve 40% performance regression by using positional capture groups - #298
Open
vjymisal0 wants to merge 1 commit into
Open
perf(parse): resolve 40% performance regression by using positional capture groups#298vjymisal0 wants to merge 1 commit into
vjymisal0 wants to merge 1 commit into
Conversation
…40% performance regression
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #273.
The recent TypeScript rewrite in \�4.0.0\ introduced a significant performance regression (>40% slower) during parsing, which was tracked down to the use of named capture groups (?\ and ?). Executing Regex with named capture groups incurs substantial overhead in V8 compared to standard positional capture groups.
By replacing the named capture groups with simple positional groups, we restore the \ms\ parsing performance back to its pre-\�4.0.0\ baseline while keeping 100% of the TypeScript safety and logic. All tests still pass!