-
Notifications
You must be signed in to change notification settings - Fork 79
runtime: add MSVC POSIX shims for Windows native builds (#25) #27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
swadhinbiswas
wants to merge
6
commits into
vercel-labs:main
Choose a base branch
from
swadhinbiswas:fix/msvc-posix-shims
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
af144df
runtime: add MSVC POSIX shims for Windows native builds
swadhinbiswas 55cbb4d
ci: add MSVC verification workflow for #25
swadhinbiswas 9bebebb
runtime: guard struct timespec and drop windows.h from header
swadhinbiswas 042c37d
runtime: remove redundant struct timespec — UCRT already defines it
swadhinbiswas 80d27b7
runtime: add POSIX compat shims for MSVC (PATH_MAX, mode_t, S_IS*)
swadhinbiswas 02c5a90
runtime: null-terminate d_name in MSVC readdir shim
swadhinbiswas File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,66 @@ | ||
| name: MSVC POSIX Shims | ||
|
|
||
| on: | ||
| push: | ||
| branches: [fix/msvc-posix-shims] | ||
| pull_request: | ||
| branches: [fix/msvc-posix-shims] | ||
|
|
||
| jobs: | ||
| msvc_compile: | ||
| name: verify MSVC compilation | ||
| runs-on: windows-latest | ||
| timeout-minutes: 15 | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - uses: pnpm/action-setup@v4 | ||
| with: | ||
| version: 11 | ||
| - uses: actions/setup-node@v4 | ||
| with: | ||
| node-version-file: .node-version | ||
| cache: pnpm | ||
| - run: pnpm install --frozen-lockfile | ||
| - run: pnpm build | ||
| - name: Compile runtime with MSVC clang | ||
| shell: pwsh | ||
| run: | | ||
| # Verify clang is MSVC-targeted (not mingw) | ||
| clang --version | ||
| # Compile a simple program — this is the exact scenario from #25 | ||
| node packages/cli/dist/main.js run tests/corpus/001-hello.ts --backend c | ||
| - name: Compile Map + sort program (the bare.ts pattern) | ||
| shell: pwsh | ||
| run: | | ||
| $ts = @' | ||
| const m = new Map<number, number>(); | ||
| m.set(1, 10); | ||
| m.set(2, 5); | ||
| m.set(3, 20); | ||
| const sorted = [...m.entries()].sort((a, b) => a[1] - b[1]); | ||
| console.log(sorted[0][0], sorted[0][1]); | ||
| '@ | ||
| $ts | Out-File -Encoding utf8 test-msvc.ts | ||
| node packages/cli/dist/main.js run test-msvc.ts --backend c | ||
|
|
||
| linux_regression: | ||
| name: verify no Linux regressions | ||
| runs-on: ubuntu-24.04 | ||
| timeout-minutes: 10 | ||
| env: | ||
| SCRIPTC_NO_CACHE: "1" | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - uses: pnpm/action-setup@v4 | ||
| with: | ||
| version: 11 | ||
| - uses: actions/setup-node@v4 | ||
| with: | ||
| node-version-file: .node-version | ||
| cache: pnpm | ||
| - run: pnpm install --frozen-lockfile | ||
| - run: pnpm build | ||
| - name: Corpus smoke tests | ||
| run: >- | ||
| SCRIPTC_TEST_WORKERS=4 pnpm exec vitest run tests/harness/differential.test.ts | ||
| -t "001-hello|518-array-sort|520-map-basics|path" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.