Skip to content

Update fixRevProperty method #726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MaximPlusov merged 2 commits into from
Apr 2, 2026
+6 −9
Merged

Update fixRevProperty method #726

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3561e4a
Update fixRevProperty method
LonelyMidoriya Mar 24, 2026
43534a9
Update MetadataImpl.java
LonelyMidoriya Apr 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 6 additions & 9 deletions metadata-fixer/src/main/java/org/verapdf/metadata/fixer/gf/impl/model/MetadataImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,7 @@ public class MetadataImpl implements Metadata {
private static final Logger LOGGER = Logger.getLogger(MetadataImpl.class.getCanonicalName());

private static final String YEAR_2020 = "2020";
private static final String YEAR_202X = "0000";
private static final String YEAR_REGEX = "^\\d{4}$";
private static final String YEAR_2024 = "2024";

private static final String ADD_PROPERTY_MESSAGE = "Added property '%s' with value '%s' to Identification schema";
private static final String REMOVE_PROPERTY_MESSAGE = "Removed property '%s' from Identification schema";
Expand Down Expand Up @@ -316,16 +315,14 @@ private void fixRevProperty(MetadataFixerResultImpl.Builder resultBuilder, PDFAF
return;
}
String namespaceURI = PDFFlavours.isFlavour(flavour, PDFAFlavour.PDFUA_2) ? XMPConst.NS_PDFUA_ID : XMPConst.NS_PDFA_ID;
String expectedRev = PDFFlavours.isFlavour(flavour, PDFAFlavour.PDFUA_2) ? YEAR_2024 : YEAR_2020;
try {
VeraPDFXMPNode rev = this.metadata.getProperty(namespaceURI, VeraPDFMeta.REVISION_YEAR);
if (rev == null) {
this.metadata.setIdentificationRevisionYear(namespaceURI, YEAR_202X);
if (rev == null || !expectedRev.equals(rev.getValue())) {
this.metadata.setIdentificationRevisionYear(namespaceURI, expectedRev);
this.setNeedToBeUpdated(true);
resultBuilder.addFix(String.format(ADD_PROPERTY_MESSAGE, VeraPDFMeta.REVISION_YEAR, YEAR_2020));
} else if (!rev.getValue().matches(YEAR_REGEX)) {
this.metadata.setIdentificationRevisionYear(namespaceURI, YEAR_202X);
this.setNeedToBeUpdated(true);
resultBuilder.addFix(String.format(SET_PROPERTY_MESSAGE, VeraPDFMeta.REVISION_YEAR, YEAR_2020));
String message = String.format((rev == null) ? ADD_PROPERTY_MESSAGE : SET_PROPERTY_MESSAGE, VeraPDFMeta.REVISION_YEAR, expectedRev);
resultBuilder.addFix(message);
}
} catch (XMPException e) {
LOGGER.log(Level.FINE, "Can not obtain identification fields.", e);
Expand Down
Loading