fix(claude-code): enable knowledge tools by default and force LF line endings#1769
Closed
benfrank241 wants to merge 1 commit into
Closed
fix(claude-code): enable knowledge tools by default and force LF line endings#1769benfrank241 wants to merge 1 commit into
benfrank241 wants to merge 1 commit into
Conversation
… endings The Claude Code marketplace distribution converts all files to CRLF. Python tolerates this, so hooks (recall, retain) work — but run_mcp.sh is a bash script and fails to parse with \r characters, preventing the MCP server from ever starting. Adding .gitattributes forces LF on checkout. Also flips enableKnowledgeTools to true in both settings.json and the DEFAULTS dict. The previous default (false) meant the MCP server exited immediately even when the user config had it set to true, if the config merge didn't take effect in time. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
\r, so hooks (recall, retain, session_start) work fine — butrun_mcp.shis a bash script and fails to parse with\rcharacters, preventing the MCP server from ever starting. Added.gitattributesto force LF on checkout.enableKnowledgeToolsdefault: Flipped fromfalsetotruein bothsettings.jsonand theDEFAULTSdict inconfig.py. The previous default meant the MCP server exited immediately even when~/.hindsight/claude-code.jsonhad the override set totrue.Test plan
run_mcp.shhas LF endingsagent_knowledge_*) appear in tool list🤖 Generated with Claude Code