fix: reload Codex OAuth credentials on auth failures#1714
Open
nicha16 wants to merge 1 commit into
Open
Conversation
- support wrapped openai-codex auth store shape - reload rotated auth.json before spending cached refresh tokens - avoid logging Codex account IDs - add regression coverage for call and tool-call paths
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
auth.jsonbefore using a cached refresh token after backend auth failures.providers.openai-codex.Why
Long-running Hindsight services can keep a stale in-memory Codex access token while another process has already rotated the shared auth file. On a backend 401, spending the cached refresh token can fail or race even though fresh credentials are already available on disk. Reloading the auth file first lets the provider adopt externally rotated credentials before attempting OAuth refresh.
Test plan
uv run pytest tests/test_codex_oauth_refresh.py tests/test_codex_tool_choice.py -q— 30 passeduv run ruff check hindsight_api/engine/providers/codex_llm.py tests/test_codex_oauth_refresh.py tests/test_codex_tool_choice.py— passedgit diff --check— passed