Skip to content

SILKIT-1966 LIN service: put master to sleep only after sleep frame received in detailed simulation#328

Merged
VJanKraemer merged 1 commit into
mainfrom
silkit-1699_lin_master_no_longer_receives_sleep_frame_with_netsim
May 19, 2026
Merged

SILKIT-1966 LIN service: put master to sleep only after sleep frame received in detailed simulation#328
VJanKraemer merged 1 commit into
mainfrom
silkit-1699_lin_master_no_longer_receives_sleep_frame_with_netsim

Conversation

@AndreasRentschler
Copy link
Copy Markdown
Contributor

Subject

Fix a bug that emerged with v5.0.4: LIN master no longer receives the go-to-sleep frame, because the master is sent to sleep too early when NetSim is used (detailed simulation). With this recent commit, a sleeping node ignores frames.

Self-reception of the go-to-sleep frame is required for CANoe to work correctly, regression test is failing.
Network simulator's integration test "ITestNetsimLin_DynamicResponse" is failing as well.

Description

This change moves transitioning of a node from SleepPending to Sleep to when the go-to-sleep frame is received and dispatched.

Tickets:

  • SILKIT-1966 LIN-Master no longer transmits go-to-sleep frame with NetSim
  • COE-114997 SIL Kit Regression Test TC 2.4 LIN is failing

Instructions for review / testing

  • Code review
  • ITests in NetSim should succeed.
  • CANoe regression test TC 2.4 should succeed.

Developer checklist (address before review)

  • Changelog.md updated
  • Prepared update for depending repositories
  • Documentation updated (public API changes only)
  • API docstrings updated (public API changes only)
  • Rebase → commit history clean
  • Squash and merge → proper PR title

@AndreasRentschler AndreasRentschler force-pushed the silkit-1699_lin_master_no_longer_receives_sleep_frame_with_netsim branch from cd3feca to 78263cb Compare May 18, 2026 13:54
@VJanKraemer
Copy link
Copy Markdown
Contributor

Something is wrong with your git Name. First name and surname are switched. That is why the DCO check is failing

@AndreasRentschler AndreasRentschler force-pushed the silkit-1699_lin_master_no_longer_receives_sleep_frame_with_netsim branch from 78263cb to 242e361 Compare May 18, 2026 16:00
…eceived in detailed simulation

Signed-off-by: Rentschler, Andreas <Andreas.Rentschler@vector.com>
@AndreasRentschler AndreasRentschler force-pushed the silkit-1699_lin_master_no_longer_receives_sleep_frame_with_netsim branch from 242e361 to 444623e Compare May 18, 2026 16:02
Copy link
Copy Markdown
Contributor

@VJanKraemer VJanKraemer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM 👍

@VJanKraemer VJanKraemer merged commit f5a3a06 into main May 19, 2026
15 checks passed
@VJanKraemer VJanKraemer deleted the silkit-1699_lin_master_no_longer_receives_sleep_frame_with_netsim branch May 19, 2026 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants