Open
Conversation
* Adds a getValue function for the specified key with proper error handling included Signed-off-by: Jan Kraemer <jan.kraemer@vector.com>
Signed-off-by: Jan Kraemer <jan.kraemer@vector.com>
In SpecificDiscoveryStore, add the label set along with the handler info to the DiscoveryCluster as "Controller" info. This allows us to do the label matching centralized in the DiscoveryStore Signed-off-by: Jan Kraemer <jan.kraemer@vector.com>
* Add test to test whether the optional label prefiltering works when the publishers are started before the Subscriber Signed-off-by: Konrad Breitsprecher <Konrad.Breitsprecher@vector.com> Co-authored-by: Jan Kraemer <jan.kraemer@vector.com>
VJanKraemer
force-pushed
the
new_labelmatcher
branch
from
b7f468d to
1a95a53
Compare
SilKit/source/util/LabelMatching.cpp
Outdated
|
|
||
| #include "LabelMatching.hpp" | ||
| #include <optional> | ||
| #include <iostream> |
Member
There was a problem hiding this comment.
Suggested change
| #include <iostream> |
Member
There was a problem hiding this comment.
The name noLabelTestDescriptor in this test is wrong, no? The baseDescriptor has a single label set (mandatory, key kA, value vA). I suppose this was copy-pasted way-back-then from the test above, where the baseDescriptor actually has no labels.
Contributor
Author
There was a problem hiding this comment.
That's what you get when you cherry pick commits without properly reviewing them :D No I stumbled across this as well but missed to fix it. Thanks :)
Signed-off-by: Marius Börschig <Marius.Boerschig@vector.com> Co-authored-by: Jan Kraemer <jan.kraemer@vector.com>
* Add comments to better explain the used algorithm, since it is somewhat convoluted Signed-off-by: Jan Kraemer <jan.kraemer@vector.com>
Signed-off-by: Jan Kraemer <jan.kraemer@vector.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the bug found in #294
Centralize the Prefiltering and Matching
Developer checklist (address before review)