fix(buffers): recheck disk buffer progress before waiting - #25988
Open
fernandol-nvidia wants to merge 2 commits into
Open
fix(buffers): recheck disk buffer progress before waiting#25988fernandol-nvidia wants to merge 2 commits into
fernandol-nvidia wants to merge 2 commits into
Conversation
Prevent disk_v2 readers from waiting for another writer notification when the shared ledger already shows an unread published record after a transient EOF.
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
|
🔗 Commit SHA: 0659219 | Docs | Datadog PR Page | Give us feedback! |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ba0bd6f40a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Author
|
I have read the CLA Document and I hereby sign the CLA |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix two
disk_v2reader coordination failures:This is related to #23605, which reports events remaining in a disk buffer until restart, and #23456, which tracks a rare reader wake-up failure in
vector-buffers. The race fixed here is reproducible on current master and the latest nightly. These issues cover broader symptoms; this PR addresses one concrete reader-side cause.The reader now uses a runtime-only published byte boundary for the active writer file. It retries while published bytes remain and waits once those bytes have been consumed. The boundary is reset on file rollover and rebuilt during recovery.
This does not change configuration or the on-disk format.
How did you test this PR?
cargo test -p vector-bufferscargo clippy -p vector-buffers --all-targets --all-features -- -D warningscargo build -p vector-buffers --releasemake check-changelog-fragmentsmake check-markdownIs this a breaking change?
Does this PR include user facing changes?
no-changeloglabel to this PR.