feat(azure_blob sink)!: make storage API version configurable - #25984
Open
opencow wants to merge 8 commits into
Open
feat(azure_blob sink)!: make storage API version configurable#25984opencow wants to merge 8 commits into
opencow wants to merge 8 commits into
Conversation
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
This comment has been minimized.
This comment has been minimized.
Author
|
I have read the CLA Document and I hereby sign the CLA |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Currently, the azure sink hardcodes the
x-ms-versionheader to2025-11-05when using Shared Key authentication. Other authentication methods use the version selected by the Azure SDK.This PR introduces an optional
api_versionfield for azure sink to override thex-ms-versionheader. This is useful when the storage service (eg. Azure Stack Hub) does not accept the version sent by vector. See:Breaking change: When
api_versionis unset, shared-key authentication now uses the sdkx-ms-versioninstead of the previously hardcoded value.Vector configuration
How did you test this PR?
I built the binary and tested it on a storage system that only supports
x-ms-versionup to a certain version. All other newer versions fail withInvalidHeaderValue, and having the overrideapi_versionresolved the issue.Is this a breaking change?
When
api_versionis unset, shared-key authentication now uses the sdkx-ms-versioninstead of the previously hardcoded value.Does this PR include user facing changes?
no-changeloglabel to this PR.References
Notes
@vectordotdev/vectorto reach out to us regarding this PR.pre-pushhook, please see this template.make fmtmake check-clippy(if there are failures it's possible some of them can be fixed withmake clippy-fix)make testgit merge origin masterandgit push.Cargo.lock), pleaserun
make build-licensesto regenerate the license inventory and commit the changes (if any). More details on the dd-rust-license-tool.