Skip to content

chore(config): consolidate schema metadata application - #25979

Open
pront wants to merge 2 commits into
masterfrom
codex/consolidate-config-metadata
Open

chore(config): consolidate schema metadata application#25979
pront wants to merge 2 commits into
masterfrom
codex/consolidate-config-metadata

Conversation

@pront

@pront pront commented Jul 30, 2026

Copy link
Copy Markdown
Member

Summary

Consolidates configurable schema metadata application without changing generated schema output.

  • replaces apply_base_metadata with the unified apply_metadata entry point across generated and handwritten schema code
  • decomposes schema metadata, custom attribute, and validation application into focused helpers while preserving their original ordering and behavior
  • removes redundant field-level title/description clearing from derive-macro output; those calls operated on a freshly defaulted Metadata
  • updates enum variant and handwritten schema call sites to use the consolidated entry point

Metadata::merge semantics remain unchanged, and regenerated component documentation has no net diff.

Vector configuration

N/A — this refactors schema generation internals and does not change Vector configuration syntax.

How did you test this PR?

On the latest origin/master:

  • make generate-docs
  • make check-generated-docs
  • cargo test -p vector-config
  • make check-clippy
  • make check-fmt
  • git diff origin/master...HEAD --check

Change Type

  • Bug fix
  • New feature
  • Dependencies
  • Non-functional (chore, refactoring, docs)
  • Performance

Is this a breaking change?

  • Yes
  • No

Does this PR include user facing changes?

  • Yes. Please add a changelog fragment based on our guidelines.
  • No. A maintainer will apply the no-changelog label to this PR.

References

#14263 — Annotate configurable types to describe their input format
#15001 — Improve generated-doc handling of schema annotations

#16366 — Fix base vs. override schema metadata handling
#15906 — Combine field and type metadata for optional fields

@github-actions github-actions Bot added the domain: sinks Anything related to the Vector's sinks label Jul 30, 2026
@datadog-vectordotdev

datadog-vectordotdev Bot commented Jul 30, 2026

Copy link
Copy Markdown

Pipelines  Tests

⚠️ Warnings

🚦 1 Pipeline job failed

Changelog | validate-changelog   View in Datadog   GitHub Actions

See error Release note not found during changelog validation. No changelog fragments detected.

ℹ️ Info

No other issues found (see more)

🧪 All tests passed
❄️ No new flaky tests detected

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 4d52eb7 | Docs | Datadog PR Page | Give us feedback!

@github-actions github-actions Bot added docs review on hold The documentation team reviews PRs only after a PR is approved by the COSE team. domain: external docs Anything related to Vector's external, public documentation and removed docs review on hold The documentation team reviews PRs only after a PR is approved by the COSE team. domain: external docs Anything related to Vector's external, public documentation labels Jul 30, 2026
@pront
pront force-pushed the codex/consolidate-config-metadata branch from 40375c7 to df890e8 Compare July 30, 2026 20:29
@pront pront added the no-changelog Changes in this PR do not need user-facing explanations in the release changelog label Jul 31, 2026
@pront
pront marked this pull request as ready for review July 31, 2026 18:29
@pront
pront requested a review from a team as a code owner July 31, 2026 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

domain: sinks Anything related to the Vector's sinks no-changelog Changes in this PR do not need user-facing explanations in the release changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant