Skip to content

enhancement(internal_logs source): Add option to rate limit internal_logs sources#25635

Open
bruceg wants to merge 1 commit into
masterfrom
bruceg/rate-limit-internal-logs-source-simple
Open

enhancement(internal_logs source): Add option to rate limit internal_logs sources#25635
bruceg wants to merge 1 commit into
masterfrom
bruceg/rate-limit-internal-logs-source-simple

Conversation

@bruceg

@bruceg bruceg commented Jun 15, 2026

Copy link
Copy Markdown
Member

Summary

The broadcast channel used to feed all internal_logs sources had always been rate limited at the same time as the console logs. This was recognized in #24218 as a bug and the rate limit was removed to provide all such sources with the full feed of internal logs. However, as some components can emit an overwhelming number of logs, applying a rate limit to this channel may be desirable as well. This change re-introduces the broadcast channel rate limit as a new command-line option with a separate window seconds value from the console limit.

Vector configuration

How did you test this PR?

Unit tests are included.

Change Type

  • Bug fix
  • New feature
  • Dependencies
  • Non-functional (chore, refactoring, docs)
  • Performance

Is this a breaking change?

  • Yes
  • No

Does this PR include user facing changes?

  • Yes. Please add a changelog fragment based on our guidelines.
  • No. A maintainer will apply the no-changelog label to this PR.

References

Notes

  • Please read our Vector contributor resources.
  • Do not hesitate to use @vectordotdev/vector to reach out to us regarding this PR.
  • Some CI checks run only after we manually approve them.
    • We recommend adding a pre-push hook, please see this template.
    • Alternatively, we recommend running the following locally before pushing to the remote branch:
      • make fmt
      • make check-clippy (if there are failures it's possible some of them can be fixed with make clippy-fix)
      • make test
  • After a review is requested, please avoid force pushes to help us review incrementally.
    • Feel free to push as many commits as you want. They will be squashed into one before merging.
    • For example, you can run git merge origin master and git push.
  • If this PR introduces changes Vector dependencies (modifies Cargo.lock), please
    run make build-licenses to regenerate the license inventory and commit the changes (if any). More details on the dd-rust-license-tool.

@bruceg bruceg requested review from a team as code owners June 15, 2026 19:50
@bruceg bruceg added type: enhancement A value-adding code change that enhances its existing functionality. domain: cli Anything related to Vector's CLI source: internal_logs Anything `internal_logs` source related labels Jun 15, 2026
@github-actions github-actions Bot added domain: sources Anything related to the Vector's sources domain: external docs Anything related to Vector's external, public documentation docs review on hold The documentation team reviews PRs only after a PR is approved by the COSE team. labels Jun 15, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 765c6a6dd5

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/trace.rs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs review on hold The documentation team reviews PRs only after a PR is approved by the COSE team. domain: cli Anything related to Vector's CLI domain: external docs Anything related to Vector's external, public documentation domain: sources Anything related to the Vector's sources source: internal_logs Anything `internal_logs` source related type: enhancement A value-adding code change that enhances its existing functionality.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants