fix(vdev): release tooling fixes from #25442#25629
Conversation
pront
added
the
no-changelog
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ff8f31528f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
pront
force-pushed
the
fix/release-tooling-improvements
branch
2 times, most recently
from
96bbcd3 to
2475df4
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2475df421f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
pront
force-pushed
the
fix/release-tooling-improvements
branch
from
059209a to
1e9a6c3
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1e9a6c3971
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
pront
force-pushed
the
fix/release-tooling-improvements
branch
3 times, most recently
from
0e2c9aa to
456dc5d
Compare
- Fix dry-run branch creation in 'vdev release prepare'. Previously, --dry-run still called git fetch and checkout_main_branch, requiring a clean remote checkout. Now those steps are skipped in dry-run mode so the command works from any local branch. A warning surfaces the current HEAD branch and the commit range that will be used, so a stale or feature branch can't silently land unrelated commits in the generated release CUE. - Fix insert_block_after_changelog inserting the VRL changelog block at the wrong position when another array closes before the changelog array. Now tracks whether we are inside the changelog: block before looking for the closing ]. - Drop scope parsing from the release CUE generator. Scopes were used by older release page layouts (pre-~0.30) to render blue badges on vector.dev but the current release template does not render them. Removes the scopes field from ConventionalParts and Commit, simplifies the regex, and drops scopes from the CUE output. The schema retains the field (defaulting to []) so existing release files continue to validate.
pront
force-pushed
the
fix/release-tooling-improvements
branch
from
456dc5d to
98b1885
Compare
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
2 participants
Summary
Small release tooling fixes, partially extracted from #25442.
Fix dry-run branch creation in
vdev release prepare--dry-runpreviously still calledgit fetchandcheckout_main_branch, requiring a clean remote checkout. Those steps are now skipped in dry-run mode so the command works from any local branch.Fix
insert_block_after_changeloginserting at the wrong positionWhen a CUE release file contains a nested array that closes before the
changelog:array, the old code inserted the VRL changelog block at the first]it encountered. Now tracks entry into thechangelog:block before looking for the closing].Drop scope parsing from the release CUE generator
Scopes were used by older release page layouts (pre-~0.30) to render blue badges on vector.dev. The current release page template does not render them. Removes the
scopesfield fromConventionalPartsandCommit, simplifies the regex, and dropsscopesfrom the CUE output. The CUE schema retains the field (defaulting to[]) so existing release files continue to validate.Vector configuration
NA
How did you test this PR?
cargo test -p vdevChange Type
Is this a breaking change?
Does this PR include user facing changes?
no-changeloglabel to this PR.References