test: split validator and sanitizer tests into per-function files by WikiRik · Pull Request #2698 · validatorjs/validator.js

WikiRik · 2026-04-15T21:24:33Z

Summary

split the remaining validator tests from test/validators.test.js into per-validator files under test/validators/
split the sanitizer tests from test/sanitizers.test.js into per-sanitizer files under test/sanitizers/ and extend test/testFunctions.js so sanitizers can use the shared helper too
most of the extraction work was done with local helper scripts and with the use of AI, with manual fixes applied where mixed blocks or lint issues needed small follow-up cleanup

Validation

ran npm test -- --grep "<name>" for each split validator and sanitizer
each run went through pretest, so build and lint also ran during validation

Background

I want to work on doing some upgrades for the next major release. This is the first major PR for it

codecov · 2026-04-15T21:25:26Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (e36b279) to head (4bfcb36).

Additional details and impacted files

@@            Coverage Diff            @@
##            master     #2698   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          114       114           
  Lines         2586      2586           
  Branches       656       656           
=========================================
  Hits          2586      2586

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copilot

Pull request overview

Refactors the test suite by splitting validator and sanitizer tests into per-function files, and extends the shared test/testFunctions.js helper to support sanitizer expectations.

Changes:

Added per-validator test files under test/validators/.
Added per-sanitizer test files under test/sanitizers/.
Updated test/testFunctions.js to support sanitizer + expect-style assertions.

Reviewed changes

Copilot reviewed 95 out of 97 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
test/testFunctions.js	Generalized helper to support both `validator` and `sanitizer`, and added `expect` assertions.
test/validators/contains.test.js	Added dedicated tests for `contains`.
test/validators/equals.test.js	Added dedicated tests for `equals`.
test/validators/matches.test.js	Added dedicated tests for `matches`.
test/validators/isWhitelisted.test.js	Added dedicated tests for `isWhitelisted`.
test/validators/isVariableWidth.test.js	Added dedicated tests for `isVariableWidth`.
test/validators/isUppercase.test.js	Added dedicated tests for `isUppercase`.
test/validators/isUUID.test.js	Added dedicated tests for `isUUID`.
test/validators/isULID.test.js	Added dedicated tests for `isULID`.
test/validators/isTime.test.js	Added dedicated tests for `isTime`.
test/validators/isSurrogatePair.test.js	Added dedicated tests for `isSurrogatePair`.
test/validators/isStrongPassword.test.js	Added dedicated tests for `isStrongPassword` (validator).
test/validators/isSlug.test.js	Added dedicated tests for `isSlug`.
test/validators/isSemVer.test.js	Added dedicated tests for `isSemVer`.
test/validators/isRgbColor.test.js	Added dedicated tests for `isRgbColor`.
test/validators/isRFC3339.test.js	Added dedicated tests for `isRFC3339`.
test/validators/isPostalCode.test.js	Added dedicated tests for `isPostalCode`.
test/validators/isPort.test.js	Added dedicated tests for `isPort`.
test/validators/isOctal.test.js	Added dedicated tests for `isOctal`.
test/validators/isNumeric.test.js	Added dedicated tests for `isNumeric`.
test/validators/isMultibyte.test.js	Added dedicated tests for `isMultibyte`.
test/validators/isMongoId.test.js	Added dedicated tests for `isMongoId`.
test/validators/isMimeType.test.js	Added dedicated tests for `isMimeType`.
test/validators/isMailtoURI.test.js	Added dedicated tests for `isMailtoURI`.
test/validators/isMagnetURI.test.js	Added dedicated tests for `isMagnetURI`.
test/validators/isMD5.test.js	Added dedicated tests for `isMD5`.
test/validators/isMACAddress.test.js	Added dedicated tests for `isMACAddress`.
test/validators/isLuhnNumber.test.js	Added dedicated tests for `isLuhnNumber`.
test/validators/isLowercase.test.js	Added dedicated tests for `isLowercase`.
test/validators/isLocale.test.js	Added dedicated tests for `isLocale`.
test/validators/isLicensePlate.test.js	Added dedicated tests for `isLicensePlate`.
test/validators/isLatLong.test.js	Added dedicated tests for `isLatLong`.
test/validators/isJWT.test.js	Added dedicated tests for `isJWT`.
test/validators/isJSON.test.js	Added dedicated tests for `isJSON`.
test/validators/isInt.test.js	Added dedicated tests for `isInt`.
test/validators/isIn.test.js	Added dedicated tests for `isIn`.
test/validators/isIdentityCard.test.js	Added dedicated tests for `isIdentityCard`.
test/validators/isISSN.test.js	Added dedicated tests for `isISSN`.
test/validators/isISRC.test.js	Added dedicated tests for `isISRC`.
test/validators/isISO8601.test.js	Added dedicated tests for `isISO8601`.
test/validators/isISO6391.test.js	Added dedicated tests for `isISO6391`.
test/validators/isISO6346.test.js	Added dedicated tests for `isISO6346`.
test/validators/isISO4217.test.js	Added dedicated tests for `isISO4217`.
test/validators/isISO31661Numeric.test.js	Added dedicated tests for `isISO31661Numeric`.
test/validators/isISO15924.test.js	Added dedicated tests for `isISO15924`.
test/validators/isISIN.test.js	Added dedicated tests for `isISIN`.
test/validators/isIPRange.test.js	Added dedicated tests for `isIPRange`.
test/validators/isIMEI.test.js	Added dedicated tests for `isIMEI`.
test/validators/isIBAN.test.js	Added dedicated tests for `isIBAN`.
test/validators/isHexadecimal.test.js	Added dedicated tests for `isHexadecimal`.
test/validators/isHexColor.test.js	Added dedicated tests for `isHexColor`.
test/validators/isHash.test.js	Added dedicated tests for `isHash`.
test/validators/isHalfWidth.test.js	Added dedicated tests for `isHalfWidth`.
test/validators/isHSL.test.js	Added dedicated tests for `isHSL`.
test/validators/isFullWidth.test.js	Added dedicated tests for `isFullWidth`.
test/validators/isFreightContainerID.test.js	Added dedicated tests for `isFreightContainerID`.
test/validators/isFloat.test.js	Added dedicated tests for `isFloat`.
test/validators/isFQDN.test.js	Expanded/organized dedicated tests for `isFQDN`.
test/validators/isEthereumAddress.test.js	Added dedicated tests for `isEthereumAddress`.
test/validators/isEmpty.test.js	Added dedicated tests for `isEmpty`.
test/validators/isEmail.test.js	Added dedicated tests for `isEmail`.
test/validators/isEAN.test.js	Added dedicated tests for `isEAN`.
test/validators/isDivisibleBy.test.js	Added dedicated tests for `isDivisibleBy`.
test/validators/isDecimal.test.js	Added dedicated tests for `isDecimal`.
test/validators/isDate.test.js	Added dedicated tests for `isDate`.
test/validators/isDataURI.test.js	Added dedicated tests for `isDataURI`.
test/validators/isCreditCard.test.js	Added dedicated tests for `isCreditCard`.
test/validators/isByteLength.test.js	Added dedicated tests for `isByteLength`.
test/validators/isBtcAddress.test.js	Added dedicated tests for `isBtcAddress`.
test/validators/isBoolean.test.js	Added dedicated tests for `isBoolean`.
test/validators/isBase58.test.js	Added dedicated tests for `isBase58`.
test/validators/isBase32.test.js	Added dedicated tests for `isBase32`.
test/validators/isBIC.test.js	Added dedicated tests for `isBIC`.
test/validators/isAscii.test.js	Added dedicated tests for `isAscii`.
test/validators/isAbaRouting.test.js	Added dedicated tests for `isAbaRouting`.
test/sanitizers/blacklist.test.js	Added dedicated tests for `blacklist` sanitizer.
test/sanitizers/escape.test.js	Added dedicated tests for `escape` sanitizer.
test/sanitizers/isStrongPassword.test.js	Added dedicated tests for `isStrongPassword` sanitizer behavior (scoring + default options).
test/sanitizers/ltrim.test.js	Added dedicated tests for `ltrim` sanitizer.
test/sanitizers/normalizeEmail.test.js	Updated to use shared `testFunctions` helper for `normalizeEmail`.
test/sanitizers/rtrim.test.js	Added dedicated tests for `rtrim` sanitizer.
test/sanitizers/stripLow.test.js	Added dedicated tests for `stripLow` sanitizer.
test/sanitizers/toBoolean.test.js	Added dedicated tests for `toBoolean` sanitizer.
test/sanitizers/toFloat.test.js	Added dedicated tests for `toFloat` sanitizer.
test/sanitizers/toInt.test.js	Added dedicated tests for `toInt` sanitizer.
test/sanitizers/trim.test.js	Added dedicated tests for `trim` sanitizer.
test/sanitizers/unescape.test.js	Added dedicated tests for `unescape` sanitizer.
test/sanitizers/whitelist.test.js	Added dedicated tests for `whitelist` sanitizer.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-04-16T03:38:30Z

 export default function test(options) {
  const args = options.args || [];
+  const method = options.validator || options.sanitizer;



test() now derives method from options.validator || options.sanitizer, but if neither is provided (or the name is misspelled), the failure will be a confusing validator[method] is not a function TypeError. Consider validating that method is set and that validator[method] is a function, and throw a clear error indicating the required option(s).

Suggested change

if (!method) {

throw new Error('test() requires either "validator" or "sanitizer" option');

}

if (typeof validator[method] !== 'function') {

throw new Error(format(

'test() received invalid validator/sanitizer "%s"; expected a function name exported by validator',

method

));

}

Copilot · 2026-04-16T03:38:31Z

+import test from '../testFunctions';
+
+describe('isISO4217', () => {
+  it('should validate ISO 4217 corrency codes', () => {


Typo in test description: "corrency" should be "currency".

Copilot · 2026-04-16T03:38:31Z

+      ],
+    });
+
+    // test where include percent is true explciitly


Typo in comment: "explciitly" should be "explicitly".

Rik Smale added 30 commits April 15, 2026 22:06

test: split isEmail validator tests

c8f6460

test: split isURL validator tests

7c3d232

test: split isMACAddress validator tests

3b1667f

test: split isIPRange validator tests

c06f58e

test: split isAlpha validator tests

b2999f6

test: split isAlphanumeric validator tests

5824d5c

test: split isNumeric validator tests

0a14840

test: split isPort validator tests

86dfd19

test: split isPassportNumber validator tests

8d4e04c

test: split isDecimal validator tests

d2916b0

test: split isLowercase validator tests

9a975eb

test: split isIMEI validator tests

e2f1f8c

test: split isUppercase validator tests

d6795d8

test: split isInt validator tests

bf82b58

test: split isFloat validator tests

bdbebf2

test: split isHexadecimal validator tests

0a88997

test: split isOctal validator tests

7269f83

test: split isHexColor validator tests

efc338d

test: split isHSL validator tests

7ea79a8

test: split isRgbColor validator tests

e57b5c1

test: split isISRC validator tests

73f1cbe

test: split isMD5 validator tests

0c2e05f

test: split isHash validator tests

2e5c3f8

test: split isJWT validator tests

a54973f

test: split isEmpty validator tests

0803680

test: split equals validator tests

d2ec7f3

test: split contains validator tests

f90c41d

test: split matches validator tests

6711e41

test: split isLocale validator tests

fb3961f

test: split isByteLength validator tests

f39c194

Rik Smale added 23 commits April 15, 2026 23:01

test: split isISO6346 validator tests

31e0c19

test: split isFreightContainerID validator tests

494c944

test: split isTaxID validator tests

74249e3

test: split isSlug validator tests

b3f6406

test: split isStrongPassword validator tests

e028ab8

test: split isDate validator tests

c8e5ec3

test: split isTime validator tests

2e01359

test: split isLicensePlate validator tests

c2259fb

test: split isVAT validator tests

3da7252

test: split isMailtoURI validator tests

cdf0c52

test: split toBoolean sanitizer tests

1a49189

test: split trim sanitizer tests

70f6cc8

test: split ltrim sanitizer tests

2ab2fc8

test: split rtrim sanitizer tests

5f69229

test: split toInt sanitizer tests

2af25c6

test: split toFloat sanitizer tests

9e16a7b

test: split escape sanitizer tests

e24d358

test: split unescape sanitizer tests

971fc82

test: split stripLow sanitizer tests

accfd9f

test: split whitelist sanitizer tests

5ccbe0f

test: split blacklist sanitizer tests

9c7caa0

test: split isStrongPassword sanitizer tests

e0e0e7c

test: split normalizeEmail sanitizer tests

4bfcb36

WikiRik marked this pull request as ready for review April 15, 2026 21:26

WikiRik requested review from profnandaa and rubiin April 15, 2026 21:26

profnandaa requested a review from Copilot April 16, 2026 03:34

Copilot started reviewing on behalf of profnandaa April 16, 2026 03:35 View session

Copilot AI reviewed Apr 16, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

test: split validator and sanitizer tests into per-function files#2698

test: split validator and sanitizer tests into per-function files#2698
WikiRik wants to merge 95 commits intomasterfrom
WikiRik/split-tests-ai

WikiRik commented Apr 15, 2026 •

edited

Loading

Uh oh!

codecov bot commented Apr 15, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Apr 16, 2026

Uh oh!

Copilot AI Apr 16, 2026

Uh oh!

Copilot AI Apr 16, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

+  if (!method) {
+    throw new Error('test() requires either "validator" or "sanitizer" option');
+  }
+  if (typeof validator[method] !== 'function') {
+    throw new Error(format(
+      'test() received invalid validator/sanitizer "%s"; expected a function name exported by validator',
+      method
+    ));
+  }

Uh oh!

Conversation

WikiRik commented Apr 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Validation

Background

Uh oh!

codecov bot commented Apr 15, 2026

Codecov Report

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Apr 16, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 16, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 16, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

WikiRik commented Apr 15, 2026 •

edited

Loading