Add a trim to the RHTPA's external secret#13
Merged
Conversation
Signed-off-by: Manuel Lorenzo <mlorenzofr@redhat.com>
Signed-off-by: Manuel Lorenzo <mlorenzofr@redhat.com>
mlorenzofr
force-pushed
the
trim-rhtpa-secret
branch
from
7a43b86 to
3085979
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apply the
trimfilter when templating the RHTPA OIDC CLIclient-secretin the ExternalSecret, so leading/trailing whitespace from the Vault value is not written into the Kubernetes secretVault (or upstream secret sources) can store the client secret with accidental whitespace or newlines. Without trimming, the synced
rhtpa-oidc-cli-secretcan contain invalid credentials and break RHTPA OIDC authentication.