Closed
Conversation
Artur-
force-pushed
the
web-components-stepper
branch
from
1c08b4b to
8ae930e
Compare
Import and adapt stepper component from reindeerplus project. Includes vaadin-stepper and vaadin-step components with: - Vertical and horizontal orientations - Small size variant - Multiple states (active, completed, error, inactive) - Step navigation with href support - Descriptions and labels - Numbered step indicators - Connector lines between steps - Full accessibility support - RTL support 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Artur-
force-pushed
the
web-components-stepper
branch
from
8ae930e to
c30a90f
Compare
- Fix disabled steps to render as div elements instead of links for better accessibility - Update test expectations to match new disabled step behavior - Remove tabindex handling for disabled links since they now render as divs - Ensure proper semantic HTML structure for disabled interactive elements 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
|
Contributor
|
This will probably require explicit design effort. It should be scheduled separately, not before 25 scope is completed. Additionally, the a11y aspect should be evaluated. |
web-padawan
requested changes
Nov 19, 2025
Member
web-padawan
left a comment
web-padawan
left a comment
There was a problem hiding this comment.
Blocking this PR for now, it needs to wait at least until 25.1 as we have now reached a feature freeze for 25.0.
Contributor
|
@rolfsmeds, we probably won't have enough capacity to complete this within the scope of 25.2. Should we close the PR and re-open it once we are ready to start working on the new components? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #5582
Import and adapt stepper component from reindeerplus project. Includes vaadin-stepper and vaadin-step components with:
🤖 Generated with Claude Code