Skip to content

[DFT][rocFFT] Fix out-of-bounds stride handling - #760

Open
zjin-lcf wants to merge 1 commit into
uxlfoundation:developfrom
zjin-lcf:fix/rocfft-commit-oob-and-stride-logic
Open

[DFT][rocFFT] Fix out-of-bounds stride handling#760
zjin-lcf wants to merge 1 commit into
uxlfoundation:developfrom
zjin-lcf:fix/rocfft-commit-oob-and-stride-logic

Conversation

@zjin-lcf

Copy link
Copy Markdown
Contributor

Summary

  • avoid out-of-range std::array subscripts in rocFFT and DFT test stride handling, which abort 3-D transforms under checked standard libraries
  • reject ranks above rocFFT's supported maximum instead of overflowing fixed-size storage
  • correct forward/backward stride validation, packed-layout checks, and the rocFFT exception label

Test plan

  • Run all rocFFT DFT functional tests on AMD Instinct MI300A with ROCm 7.2.4: 667 passed, 272 skipped, 0 failed
  • Repeat the full suite with -D_GLIBCXX_ASSERTIONS: 667 passed, 272 skipped, 0 failed
  • Verify baseline and fixed runs have identical skipped-test lists
  • Verify 1-D, 2-D, and 3-D descriptor commits succeed under checked libstdc++; 4-D and 5-D commits throw unimplemented
  • Run the pre-commit clang-format hook

Reject unsupported ranks and avoid invalid array subscripts so checked builds handle 3-D transforms safely, while correcting stride validation semantics.

Co-authored-by: Cursor <cursoragent@cursor.com>
@zjin-lcf
zjin-lcf requested a review from a team as a code owner August 14, 2026 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant