[CMake] Accept legacy 'hipsycl' as deprecated alias for 'adaptivecpp' - #751
Open
zjin-lcf wants to merge 1 commit into
Open
[CMake] Accept legacy 'hipsycl' as deprecated alias for 'adaptivecpp'#751zjin-lcf wants to merge 1 commit into
zjin-lcf wants to merge 1 commit into
Conversation
hipSYCL was renamed to AdaptiveCpp (uxlfoundation#699), and ONEMATH_SYCL_IMPLEMENTATION now only accepts 'adaptivecpp'. Users following older instructions that pass 'hipsycl' hit a fatal "implementation is not known" error. Map the legacy value to 'adaptivecpp' and emit a deprecation warning so existing build scripts keep working. Addresses uxlfoundation#711. Co-authored-by: Cursor <cursoragent@cursor.com>
sknepper
approved these changes
Aug 13, 2026
Contributor
Author
|
Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses #711.
hipSYCL was renamed to AdaptiveCpp, and #699 updated
ONEMATH_SYCL_IMPLEMENTATION(and all internal references / docs) to useadaptivecpp. As a result, users following older instructions or scripts that pass-DONEMATH_SYCL_IMPLEMENTATION=hipsyclnow hit a fatal error:This PR accepts the legacy
hipsyclvalue as a deprecated alias foradaptivecpp, emitting a deprecation warning that points users to the new value, so existing build scripts keep working:Note: the original report (v0.9) predates #699; on current
developthe docs and CMake already agree onadaptivecpp. This change only adds backward compatibility for the old spelling.Test plan
-DONEMATH_SYCL_IMPLEMENTATION=adaptivecppunchanged.-DONEMATH_SYCL_IMPLEMENTATION=hipsycl(andhipSYCL, via existingTOLOWER) now maps to AdaptiveCpp with a deprecation warning instead of failing.