Skip to content

[CMake] Accept legacy 'hipsycl' as deprecated alias for 'adaptivecpp' - #751

Open
zjin-lcf wants to merge 1 commit into
uxlfoundation:developfrom
zjin-lcf:fix/cmake-hipsycl-alias-711
Open

[CMake] Accept legacy 'hipsycl' as deprecated alias for 'adaptivecpp'#751
zjin-lcf wants to merge 1 commit into
uxlfoundation:developfrom
zjin-lcf:fix/cmake-hipsycl-alias-711

Conversation

@zjin-lcf

Copy link
Copy Markdown
Contributor

Summary

Addresses #711.

hipSYCL was renamed to AdaptiveCpp, and #699 updated ONEMATH_SYCL_IMPLEMENTATION (and all internal references / docs) to use adaptivecpp. As a result, users following older instructions or scripts that pass -DONEMATH_SYCL_IMPLEMENTATION=hipsycl now hit a fatal error:

SYCL implementation hipsycl is not known

This PR accepts the legacy hipsycl value as a deprecated alias for adaptivecpp, emitting a deprecation warning that points users to the new value, so existing build scripts keep working:

if (ONEMATH_SYCL_IMPLEMENTATION STREQUAL "hipsycl")
  message(WARNING "ONEMATH_SYCL_IMPLEMENTATION=hipsycl is deprecated: ... Treating it as 'adaptivecpp'. Please use -DONEMATH_SYCL_IMPLEMENTATION=adaptivecpp instead.")
  set(ONEMATH_SYCL_IMPLEMENTATION "adaptivecpp")
endif()

Note: the original report (v0.9) predates #699; on current develop the docs and CMake already agree on adaptivecpp. This change only adds backward compatibility for the old spelling.

Test plan

  • -DONEMATH_SYCL_IMPLEMENTATION=adaptivecpp unchanged.
  • -DONEMATH_SYCL_IMPLEMENTATION=hipsycl (and hipSYCL, via existing TOLOWER) now maps to AdaptiveCpp with a deprecation warning instead of failing.
  • Unknown values still produce the existing fatal error.

hipSYCL was renamed to AdaptiveCpp (uxlfoundation#699), and ONEMATH_SYCL_IMPLEMENTATION
now only accepts 'adaptivecpp'. Users following older instructions that
pass 'hipsycl' hit a fatal "implementation is not known" error. Map the
legacy value to 'adaptivecpp' and emit a deprecation warning so existing
build scripts keep working.

Addresses uxlfoundation#711.

Co-authored-by: Cursor <cursoragent@cursor.com>
@zjin-lcf
zjin-lcf requested a review from a team as a code owner August 11, 2026 02:32

@sknepper sknepper left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - it makes sense to accept the hipsycl alias to preserve backward compatibility for existing build scripts.

@zjin-lcf

Copy link
Copy Markdown
Contributor Author

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants