implemented runuser - #612
Open
mustafaelrasheid wants to merge 7 commits into
Open
Conversation
sylvestre
reviewed
Aug 13, 2026
| .map(|s| s.to_string()) | ||
| .collect::<Vec<_>>() | ||
| .to_vec(); | ||
| let (username, path, command_args) = match matches.get_one::<String>("user") { |
Contributor
There was a problem hiding this comment.
maybe move this into a function?
Author
There was a problem hiding this comment.
Just to clarify, do you mean the parsing for username, path and command_args or the entirety of the args parsing?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've implemented a basic version of runuser and I feel honored to be able to share it.
This is my first ever contribution and I was a bit hesitant to share it because of how complex the argument parsing was, but it came out well.