sort: report merge output flush errors - #13910
Conversation
|
GNU testsuite comparison: |
Merging this PR will regress 1 benchmark
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ❌ | Simulation | numfmt_large_numbers_si[10000] |
94.7 ms | 98.1 ms | -3.4% |
| ⚡ | Simulation | df_with_path |
704.9 µs | 573.7 µs | +22.86% |
| 🆕 | Memory | ptx_input_references_short_lines[100000] |
N/A | 222.2 MB | N/A |
| 🆕 | Memory | ptx_long_lines[100] |
N/A | 29.5 MB | N/A |
| 🆕 | Memory | ptx_short_lines[100000] |
N/A | 240.1 MB | N/A |
| 🆕 | Memory | ptx_input_references_long_lines[1000] |
N/A | 29.1 MB | N/A |
| 🆕 | Memory | ptx_tex[10000] |
N/A | 20.6 MB | N/A |
| 🆕 | Simulation | ptx_input_references_short_lines[100000] |
N/A | 16.2 s | N/A |
| 🆕 | Simulation | ptx_long_lines[100] |
N/A | 1.7 s | N/A |
| 🆕 | Simulation | ptx_short_lines[100000] |
N/A | 14 s | N/A |
| 🆕 | Simulation | ptx_input_references_long_lines[1000] |
N/A | 2 s | N/A |
| 🆕 | Simulation | ptx_tex[10000] |
N/A | 2.9 s | N/A |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing DePasqualeOrg:sort-output-write-errors (4265a9c) with main (66cf72b)2
Footnotes
-
46 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
-
No successful run was found on
main(e1efa7d) during the generation of this report, so 66cf72b was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩
Unlike ordinary
sortoutput,sort --mergedid not flush its output before returning. This could hide a write failure and causesortto exit successfully. This change adds the missing flush and a regression test.An automated review with Codex found separate error-handling problems that are not addressed here. I'm flagging them for potential future work: