od: wrap offset instead of overflowing on a large --traditional label - #13896
Open
AlejandroCoronadoN wants to merge 1 commit into
Open
od: wrap offset instead of overflowing on a large --traditional label#13896AlejandroCoronadoN wants to merge 1 commit into
AlejandroCoronadoN wants to merge 1 commit into
Conversation
…abel InputOffset::increase_position used unchecked u64 arithmetic, so a --traditional label near u64::MAX aborted on the first read. Byte offset and label are fixed-width addresses, so wrap them like GNU od. Adds a unit test. Fixes uutils#13225.
Merging this PR will degrade performance by 18.61%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ❌ | Simulation | df_with_path |
573.7 µs | 704.9 µs | -18.61% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing AlejandroCoronadoN:fix-od-traditional-offset-overflow (573a3a8) with main (822aa83)
Footnotes
-
46 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In
--traditionalmode,odaccepts a pseudo-address label. A label nearu64::MAXoverflows the offset accumulator on the first read:
(under
-C overflow-checks).Root cause
InputOffset::increase_positionused uncheckedu64arithmetic(
self.byte_pos += n,self.label = Some(l + n)).Fix
Use
wrapping_add. The byte offset and label are fixed-width addresses, so wrapping(as GNU od does) is the correct behavior and cannot overflow. Adds a unit test.
Fixes #13225.