use imports instead of absolute path when using strip_errno - #13892
Open
Devel08 wants to merge 1 commit into
Open
use imports instead of absolute path when using strip_errno#13892Devel08 wants to merge 1 commit into
Devel08 wants to merge 1 commit into
Conversation
Devel08
marked this pull request as draft
August 12, 2026 08:43
Merging this PR will degrade performance by 3.78%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ❌ | Simulation | df_with_path |
573.7 µs | 704.7 µs | -18.59% |
| ⚡ | Simulation | du_summarize_balanced_tree[(5, 4, 10)] |
16.8 ms | 16 ms | +4.83% |
| ⚡ | Simulation | du_max_depth_balanced_tree[(6, 4, 10)] |
65.2 ms | 62.4 ms | +4.39% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing Devel08:strip-errno-absolute-path (d79451a) with main (822aa83)
Footnotes
-
282 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
oech3
reviewed
Aug 12, 2026
oech3
reviewed
Aug 12, 2026
seperate import for sync group strip_errno in false.rs Co-authored-by: oech3 <79379754+oech3@users.noreply.github.com> remove redudant import and move import to conditional compilation in sync Apply suggestions from code review Co-authored-by: oech3 <79379754+oech3@users.noreply.github.com> cargo fmt group strip_errno in uucore import group import in unix.rs group imports
Devel08
force-pushed
the
strip-errno-absolute-path
branch
from
August 12, 2026 09:25
15983b0 to
d79451a
Compare
Devel08
marked this pull request as ready for review
August 12, 2026 09:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
that was found with
grep -r "uucore::error::strip_errno(" .