Skip to content

use imports instead of absolute path when using strip_errno - #13892

Open
Devel08 wants to merge 1 commit into
uutils:mainfrom
Devel08:strip-errno-absolute-path
Open

use imports instead of absolute path when using strip_errno#13892
Devel08 wants to merge 1 commit into
uutils:mainfrom
Devel08:strip-errno-absolute-path

Conversation

@Devel08

@Devel08 Devel08 commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

that was found with grep -r "uucore::error::strip_errno(" .

@Devel08
Devel08 marked this pull request as draft August 12, 2026 08:43
@codspeed-hq

codspeed-hq Bot commented Aug 12, 2026

Copy link
Copy Markdown

Merging this PR will degrade performance by 3.78%

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 2 improved benchmarks
❌ 1 regressed benchmark
✅ 108 untouched benchmarks
⏩ 282 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation df_with_path 573.7 µs 704.7 µs -18.59%
Simulation du_summarize_balanced_tree[(5, 4, 10)] 16.8 ms 16 ms +4.83%
Simulation du_max_depth_balanced_tree[(6, 4, 10)] 65.2 ms 62.4 ms +4.39%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing Devel08:strip-errno-absolute-path (d79451a) with main (822aa83)

Open in CodSpeed

Footnotes

  1. 282 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

Comment thread src/uu/false/src/false.rs
Comment thread src/uu/mkdir/src/mkdir.rs Outdated
Comment thread src/uu/od/src/multifile_reader.rs Outdated
Comment thread src/uu/split/src/platform/unix.rs Outdated
Comment thread src/uu/sync/src/sync.rs
Comment thread src/uu/true/src/true.rs Outdated
@cakebaker cakebaker changed the title use imports instead of absoulte path when using strip_errno use imports instead of absolute path when using strip_errno Aug 12, 2026
seperate import for sync

group strip_errno in false.rs

Co-authored-by: oech3 <79379754+oech3@users.noreply.github.com>

remove redudant import and move import to conditional compilation in sync

Apply suggestions from code review

Co-authored-by: oech3 <79379754+oech3@users.noreply.github.com>

cargo fmt

group strip_errno in uucore import

group import in unix.rs

group imports
@Devel08
Devel08 force-pushed the strip-errno-absolute-path branch from 15983b0 to d79451a Compare August 12, 2026 09:25
@Devel08
Devel08 marked this pull request as ready for review August 12, 2026 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants