strip errno when argument is not a directory but an existing file - #13890
Conversation
| writeln!( | ||
| std::io::stderr(), | ||
| "{}", | ||
| format_args!("pathchk: {}: {}", path, uucore::error::strip_errno(&e)) |
There was a problem hiding this comment.
maybe use show_error https://docs.rs/uucore/latest/uucore/macro.show_error.html
Merging this PR will degrade performance by 3.69%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ❌ | Simulation | df_with_path |
573.7 µs | 704.6 µs | -18.58% |
| ⚡ | Simulation | du_max_depth_balanced_tree[(6, 4, 10)] |
65.2 ms | 62.2 ms | +4.83% |
| ⚡ | Simulation | du_summarize_balanced_tree[(5, 4, 10)] |
16.8 ms | 16 ms | +4.67% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing Devel08:fix-issue-13888 (73a3d7c) with main (822aa83)
Footnotes
-
46 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
| "{}", | ||
| format_args!("pathchk: {}: {}", path, uucore::error::strip_errno(&e)) | ||
| ); | ||
| uucore::show_error!("{}: {}", path, uucore::error::strip_errno(&e)); |
There was a problem hiding this comment.
please use the import for both, don't declare uucore:
2 participants
closes #13888