Revert "ci: trust preinstalled Homebrew taps on macOS" - #13875
Conversation
This reverts commit c63f02e.
|
actions/runner-images#14543 is not yet targeting a release, keeping as a draft. |
|
Binary size comparison: |
Merging this PR will improve performance by 3.86%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ⚡ | Simulation | du_max_depth_balanced_tree[(6, 4, 10)] |
64.7 ms | 62.2 ms | +3.95% |
| ⚡ | Simulation | du_summarize_balanced_tree[(5, 4, 10)] |
16.6 ms | 16 ms | +3.77% |
Tip
Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.
Comparing xtqqczze:revert-tap-trust (70a97bc) with main (fb71685)
Footnotes
-
46 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
|
GNU testsuite comparison: |
This comment was marked as resolved.
This comment was marked as resolved.
There was a problem hiding this comment.
Pull request overview
This PR reverts a temporary GitHub Actions workaround that explicitly trusted a preinstalled Homebrew tap on macOS runners, based on the upstream runner-images change having been completed.
Changes:
- Remove the “Trust preinstalled Homebrew taps” (
brew trust aws/tap) step from multiple jobs in the l10n workflow. - Remove the same Homebrew trust step from macOS-related jobs in the main CI/CD workflow.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/l10n.yml | Removes the macOS-only Homebrew tap trust workaround from affected l10n jobs. |
| .github/workflows/CICD.yml | Removes the macOS-only Homebrew tap trust workaround from affected CI jobs. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This reverts commit c63f02e.
actions/runner-images#14543 was completed upstream.