Skip to content

Revert "ci: trust preinstalled Homebrew taps on macOS" - #13875

Merged
sylvestre merged 1 commit into
uutils:mainfrom
xtqqczze:revert-tap-trust
Aug 13, 2026
Merged

Revert "ci: trust preinstalled Homebrew taps on macOS"#13875
sylvestre merged 1 commit into
uutils:mainfrom
xtqqczze:revert-tap-trust

Conversation

@xtqqczze

@xtqqczze xtqqczze commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

This reverts commit c63f02e.

actions/runner-images#14543 was completed upstream.

@xtqqczze

Copy link
Copy Markdown
Contributor Author

actions/runner-images#14543 is not yet targeting a release, keeping as a draft.

@github-actions

Copy link
Copy Markdown

Binary size comparison:

Individual binary size comparison VS main (threshold: >=5% AND >=4 KB).

Total size of compared binaries: 148.94 MB (+324 KB, +0.21%)

Significant per-binary changes:
  install     1.24 MB ->    1.32 MB  (+80 KB, +6.29%)
  mkdir       1.09 MB ->    1.17 MB  (+80 KB, +7.14%)
  mkfifo      1.09 MB ->    1.16 MB  (+76 KB, +6.83%)
  mknod       1.09 MB ->    1.17 MB  (+76 KB, +6.79%)

@codspeed-hq

codspeed-hq Bot commented Aug 11, 2026

Copy link
Copy Markdown

Merging this PR will improve performance by 3.86%

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 2 improved benchmarks
✅ 345 untouched benchmarks
⏩ 46 skipped benchmarks1

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation du_max_depth_balanced_tree[(6, 4, 10)] 64.7 ms 62.2 ms +3.95%
Simulation du_summarize_balanced_tree[(5, 4, 10)] 16.6 ms 16 ms +3.77%

Tip

Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.


Comparing xtqqczze:revert-tap-trust (70a97bc) with main (fb71685)

Open in CodSpeed

Footnotes

  1. 46 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@github-actions

Copy link
Copy Markdown

GNU testsuite comparison:

Skipping an intermittent issue tests/cut/bounded-memory (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/tail/retry (passes in this run but fails in the 'main' branch)
Note: The gnu test tests/misc/write-errors was skipped on 'main' but is now failing.

@oech3

This comment was marked as resolved.

@sylvestre
sylvestre marked this pull request as ready for review August 13, 2026 11:30
Copilot AI lite review requested due to automatic review settings August 13, 2026 11:30
@sylvestre
sylvestre merged commit 0c1b832 into uutils:main Aug 13, 2026
164 checks passed

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR reverts a temporary GitHub Actions workaround that explicitly trusted a preinstalled Homebrew tap on macOS runners, based on the upstream runner-images change having been completed.

Changes:

  • Remove the “Trust preinstalled Homebrew taps” (brew trust aws/tap) step from multiple jobs in the l10n workflow.
  • Remove the same Homebrew trust step from macOS-related jobs in the main CI/CD workflow.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
.github/workflows/l10n.yml Removes the macOS-only Homebrew tap trust workaround from affected l10n jobs.
.github/workflows/CICD.yml Removes the macOS-only Homebrew tap trust workaround from affected CI jobs.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@xtqqczze
xtqqczze deleted the revert-tap-trust branch August 13, 2026 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants