mkdir: quote invalid modes in diagnostics - #13862
Open
0Whisperos wants to merge 1 commit into
Open
Conversation
Use C-style quoting for invalid mode errors when stderr is not a terminal. Escape control characters in rich mode diagnostics while preserving the highlighted span.
|
Binary size comparison: |
|
GNU testsuite comparison: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #13834.
mkdir -mnow handles invalid modes consistently across stderr environments:invalid mode 'a=\001'.This keeps non-printable mode characters visible instead of emitting them directly to stderr.
Tests cover both piped and terminal stderr for
a=\x01.