cp: fix --remove-destination deleting source when dest is the same file under a different path#13135
Open
LoukasPap wants to merge 1 commit into
Open
cp: fix --remove-destination deleting source when dest is the same file under a different path#13135LoukasPap wants to merge 1 commit into
LoukasPap wants to merge 1 commit into
Conversation
Merging this PR will not alter performance
Comparing Footnotes
|
|
GNU testsuite comparison: |
Author
|
Is there a way to test the performance locally or before pushing? |
…le under a different path
Author
|
Changed order of conditions to allow same-file check to happen only when --remove-destination param is set, thus avoiding redundant comparison of source and dest. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #13103
Problem
It compared the source and destination inputs as passed, so for example "a" and "./a" were compared and were -of course- found different.
Solution
We convert them to absolute paths using
canonicalize(...)and then perform the equality check.