minorbug(cp): io error messages vague when using -g#13110
Open
Devel08 wants to merge 4 commits into
Open
Conversation
|
GNU testsuite comparison: |
cakebaker
reviewed
Jun 28, 2026
Comment on lines
838
to
854
| if let CpError::NotAllFilesCopied = error { | ||
| // Error::NotAllFilesCopied is non-fatal, but the error | ||
| // code should still be EXIT_ERR as does GNU cp | ||
| } else { | ||
| // Else we caught a fatal bubbled-up error, log it to stderr | ||
| show_error!("{error}"); | ||
|
|
||
| if let CpError::IoErr(error) = error { | ||
| if error.kind() == io::ErrorKind::NotFound { | ||
| show_error!( | ||
| "{}", | ||
| translate!("cp-error-cannot-stat", "source" => format!("'{}'",sources[0].display())) | ||
| ); | ||
| } | ||
| } else { | ||
| show_error!("{error}"); | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
I would use a match instead of the if let/else chain.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this PR closes #13097