Skip to content

coreutils: remove invalid fallback for symlinks from binary_path#13088

Open
oech3 wants to merge 1 commit into
uutils:mainfrom
oech3:core-valid-unwrap
Open

coreutils: remove invalid fallback for symlinks from binary_path#13088
oech3 wants to merge 1 commit into
uutils:mainfrom
oech3:core-valid-unwrap

Conversation

@oech3

@oech3 oech3 commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

current_exe() (/proc/self/exe) resolves symlink. So args.next.unwrap() is the best effort at here and empty arg does not happen generally.

@oech3 oech3 force-pushed the core-valid-unwrap branch from 88c74a1 to f8a4ab7 Compare June 26, 2026 07:02
@github-actions

github-actions Bot commented Jun 26, 2026

Copy link
Copy Markdown

GNU testsuite comparison:

Skip an intermittent issue tests/cut/bounded-memory (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/date/date-locale-hour (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/tail/retry (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/tail/symlink (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/misc/tty-eof (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/tail/inotify-dir-recreate (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/basenc/bounded-memory is now passing!
Congrats! The gnu test tests/seq/seq-epipe is now passing!

@oech3 oech3 marked this pull request as ready for review June 26, 2026 07:22
@oech3 oech3 force-pushed the core-valid-unwrap branch from f8a4ab7 to 1f63cdc Compare June 26, 2026 07:42
@oech3 oech3 force-pushed the core-valid-unwrap branch from 1f63cdc to 0635651 Compare June 27, 2026 09:08
@sylvestre

Copy link
Copy Markdown
Contributor

what is the issue you are trying to fix ?

@oech3

oech3 commented Jun 28, 2026

Copy link
Copy Markdown
Contributor Author

It this is reachable code, it potentially resolves incorrect utility name. I want to avoid it.
If this is unreachable code, it should be removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants