Skip to content

cksum: Fix --check filename escaping for 9.11#12156

Open
RenjiSann wants to merge 1 commit intouutils:mainfrom
RenjiSann:cksum-fix-escaping
Open

cksum: Fix --check filename escaping for 9.11#12156
RenjiSann wants to merge 1 commit intouutils:mainfrom
RenjiSann:cksum-fix-escaping

Conversation

@RenjiSann
Copy link
Copy Markdown
Collaborator

@RenjiSann RenjiSann commented May 5, 2026

This should fix the md5sum-bsd test, which started failing since the 9.11 release, because GNU switched to shell escaping to print filenames

@RenjiSann RenjiSann force-pushed the cksum-fix-escaping branch 2 times, most recently from a207464 to 8d4e30e Compare May 5, 2026 16:18
@RenjiSann RenjiSann force-pushed the cksum-fix-escaping branch from 8d4e30e to 397a70e Compare May 5, 2026 16:24
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 5, 2026

GNU testsuite comparison:

GNU test failed: tests/tail/retry. tests/tail/retry is passing on 'main'. Maybe you have to rebase?
Skipping an intermittent issue tests/cut/bounded-memory (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/cksum/md5sum-bsd is no longer failing!

),
(
b"funky\xffname",
os_str_from_bytes(b"funky\xffname").unwrap().to_os_string(),
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
os_str_from_bytes(b"funky\xffname").unwrap().to_os_string(),
#[allow(clippy::unwrap_used, reason = "deterministic unwrap would not panic")]
os_str_from_bytes(b"funky\xffname").unwrap().to_os_string(),

@sylvestre
Copy link
Copy Markdown
Contributor

some jobs are failing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants