sort:Add sort long-line locale benchmark#12150
Open
mattsu2020 wants to merge 1 commit intouutils:mainfrom
Open
sort:Add sort long-line locale benchmark#12150mattsu2020 wants to merge 1 commit intouutils:mainfrom
mattsu2020 wants to merge 1 commit intouutils:mainfrom
Conversation
|
GNU testsuite comparison: |
Merging this PR will degrade performance by 4.66%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ❌ | Simulation | sort_ascii_utf8_locale |
15.4 ms | 16.1 ms | -4.66% |
| 🆕 | Simulation | sort_long_ascii_lines_utf8_locale[1048576] |
N/A | 56 ms | N/A |
| 🆕 | Memory | sort_long_ascii_lines_utf8_locale[1048576] |
N/A | 36 MB | N/A |
Comparing mattsu2020:codex/sort-long-line-benchmark (acc9a16) with main (c23dc67)
Footnotes
-
46 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
--parallel 1 --buffer-size 8G.Why
This covers the long-line locale collation case discussed in #12144 and #12138 without adding a multi-GiB benchmark input.
Validation
cargo check -p uu_sort --benchescargo bench -p uu_sort --bench sort_locale_utf8_bench sort_long_ascii_lines_utf8_localeObserved local benchmark result: