Skip to content

nl: continue if a file can't be opened#11983

Open
cakebaker wants to merge 1 commit intouutils:mainfrom
cakebaker:nl_multiple_files_with_missing
Open

nl: continue if a file can't be opened#11983
cakebaker wants to merge 1 commit intouutils:mainfrom
cakebaker:nl_multiple_files_with_missing

Conversation

@cakebaker
Copy link
Copy Markdown
Contributor

Currently, we stop processing the specified files if one can't be opened whereas GNU nl keeps processing.

This PR fixes the issue. It should make the multiple-files.sh GNU test pass.

@github-actions
Copy link
Copy Markdown

GNU testsuite comparison:

Skipping an intermittent issue tests/tail/symlink (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/cp/sparse-to-pipe is no longer failing!
Congrats! The gnu test tests/nl/multiple-files is no longer failing!
Congrats! The gnu test tests/nl/nl is no longer failing!
Congrats! The gnu test tests/tail/pipe-f2 is no longer failing!
Congrats! The gnu test tests/basenc/bounded-memory is now passing!
Congrats! The gnu test tests/rm/many-dir-entries-vs-OOM is now passing!
Note: The gnu test tests/misc/write-errors was skipped on 'main' but is now failing.
Skip an intermittent issue tests/pr/bounded-memory (was skipped on 'main', now failing)

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Apr 24, 2026

Merging this PR will not alter performance

✅ 313 untouched benchmarks
⏩ 46 skipped benchmarks1


Comparing cakebaker:nl_multiple_files_with_missing (f22c43e) with main (2e04477)2

Open in CodSpeed

Footnotes

  1. 46 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

  2. No successful run was found on main (852af48) during the generation of this report, so 2e04477 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@cakebaker cakebaker requested a review from sylvestre April 30, 2026 07:16
@sylvestre sylvestre force-pushed the nl_multiple_files_with_missing branch from fcc1104 to f22c43e Compare May 5, 2026 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant