Skip to content

install: refactor conditional expression #11280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cakebaker merged 1 commit into from
Mar 10, 2026
Merged

install: refactor conditional expression #11280

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 15 additions & 16 deletions src/uu/install/src/install.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1259,27 +1259,26 @@ fn need_copy(from: &Path, to: &Path, b: &Behavior) -> bool {
return true;
}

#[cfg(all(feature = "selinux", target_os = "linux"))]
if !b.unprivileged && b.preserve_context && contexts_differ(from, to) {
return true;
}
if !b.unprivileged {
#[cfg(all(feature = "selinux", target_os = "linux"))]
if b.preserve_context && contexts_differ(from, to) {
return true;
}

// TODO: if -P (#1809) and from/to contexts mismatch, return true.
// TODO: if -P (#1809) and from/to contexts mismatch, return true.

// Check if the owner ID is specified and differs from the destination file's owner.
if let Some(owner_id) = b.owner_id {
if !b.unprivileged && owner_id != to_meta.uid() {
return true;
// Check if the owner ID is specified and differs from the destination file's owner.
match b.owner_id {
Some(uid) if uid != to_meta.uid() => return true,
_ => {}
}
}

// Check if the group ID is specified and differs from the destination file's group.
if let Some(group_id) = b.group_id {
if !b.unprivileged && group_id != to_meta.gid() {
return true;
// Check if the group ID is specified and differs from the destination file's group.
match b.group_id {
Some(gid) if gid != to_meta.gid() => return true,
None if needs_copy_for_ownership(to, &to_meta) => return true,
_ => {}
}
} else if !b.unprivileged && needs_copy_for_ownership(to, &to_meta) {
return true;
}

// Check if the contents of the source and destination files differ.
Expand Down
Loading