df: replace unsafe libc sync with nix crate#11279
Open
mattsu2020 wants to merge 1 commit intouutils:mainfrom
Open
df: replace unsafe libc sync with nix crate#11279mattsu2020 wants to merge 1 commit intouutils:mainfrom
mattsu2020 wants to merge 1 commit intouutils:mainfrom
Conversation
Replace the unsafe libc sync call with the nix crate's sync_filesystems function for safer filesystem synchronization. This change improves code safety by using a well-maintained Rust wrapper instead of direct unsafe libc calls.
mattsu2020
changed the title
|
GNU testsuite comparison: |
Contributor
|
|
xtqqczze
reviewed
Mar 10, 2026
| #[cfg(target_os = "android")] | ||
| uucore::libc::syscall(uucore::libc::SYS_sync); | ||
| } | ||
| sync_filesystems(); |
Contributor
There was a problem hiding this comment.
Suggested change
| sync_filesystems(); | |
| nix::unistd::sync(); |
fully qualified is more more clear than type alias
xtqqczze
suggested changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the unsafe libc sync call with the nix crate's sync_filesystems function for safer filesystem synchronization. This change improves code safety by using a well-maintained Rust wrapper instead of direct unsafe libc calls.