Skip to content

wc: increase buffer size for Unicode counting paths #11276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mattsu2020 wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −3
Open

wc: increase buffer size for Unicode counting paths #11276

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/uu/wc/src/countable.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@ use std::io::{BufRead, BufReader, Read, StdinLock};
#[cfg(unix)]
use std::os::fd::{AsFd, AsRawFd};

const WORD_COUNT_BUF_SIZE: usize = 256 * 1024;

#[cfg(unix)]
pub trait WordCountable: AsFd + AsRawFd + Read {
type Buffered: BufRead;
Expand All @@ -28,10 +30,10 @@ pub trait WordCountable: Read {
}

impl WordCountable for StdinLock<'_> {
type Buffered = Self;
type Buffered = BufReader<Self>;

fn buffered(self) -> Self::Buffered {
self
BufReader::with_capacity(WORD_COUNT_BUF_SIZE, self)
}
fn inner_file(&mut self) -> Option<&mut File> {
None
Expand All @@ -42,7 +44,7 @@ impl WordCountable for File {
type Buffered = BufReader<Self>;

fn buffered(self) -> Self::Buffered {
BufReader::new(self)
BufReader::with_capacity(WORD_COUNT_BUF_SIZE, self)
}

fn inner_file(&mut self) -> Option<&mut File> {
Expand Down
Loading