Skip to content

make.yml :Switch to stable from MSRV #11273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sylvestre merged 1 commit into from
Mar 11, 2026
Merged

make.yml :Switch to stable from MSRV #11273

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 4 additions & 16 deletions .github/workflows/make.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,15 +3,15 @@ name: make
# spell-checker:ignore (abbrev/names) CACHEDIR taiki
# spell-checker:ignore (env/flags) RUSTDOCFLAGS RUSTFLAGS CARGOFLAGS CLEVEL
# spell-checker:ignore (jargon) deps softprops toolchain
# spell-checker:ignore (people) dawidd dtolnay
# spell-checker:ignore (people) dawidd
# spell-checker:ignore (shell/tools) nextest sccache zstd
# spell-checker:ignore (misc) aarch bindir busytest defconfig DESTDIR manpages multisize runtest Swatinem testsuite toybox uutils
# spell-checker:ignore (misc) bindir busytest defconfig DESTDIR manpages multisize runtest Swatinem testsuite toybox uutils

env:
PROJECT_NAME: coreutils
PROJECT_DESC: "Core universal (cross-platform) utilities"
PROJECT_AUTH: "uutils"
RUST_MIN_SRV: "1.88.0"
CARGO_INCREMENTAL: 0
# * style job configuration
STYLE_FAIL_ON_FAULT: true ## (bool) fail the build if a style job contains a fault (error or warning); may be overridden on a per-job basis

Expand All @@ -37,8 +37,6 @@ jobs:
permissions:
contents: write # Publish individual binaries
runs-on: ${{ matrix.job.os }}
env:
CARGO_INCREMENTAL: 0
strategy:
fail-fast: false
matrix:
Expand All @@ -48,9 +46,6 @@ jobs:
- uses: actions/checkout@v6
with:
persist-credentials: false
- uses: dtolnay/rust-toolchain@stable
with:
target: aarch64-unknown-linux-gnu
- uses: taiki-e/install-action@nextest
- uses: Swatinem/rust-cache@v2
# Test build on the system missing libselinux (don't install libselinux1-dev at here)
Expand All @@ -74,7 +69,7 @@ jobs:
mv -T target target.cache
fi
# Check that we don't cross-build uudoc
env CARGO_BUILD_TARGET=aarch64-unknown-linux-gnu make install-manpages PREFIX=/tmp/usr UTILS=true
env CARGO_BUILD_TARGET=invalid-unknown-linux-gnu make install-manpages PREFIX=/tmp/usr UTILS=true
Copy link
Contributor

@xtqqczze xtqqczze Mar 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

invalid?

Copy link
Contributor Author

@oech3 oech3 Mar 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. The string is not needed to be an existing one. It just checks that we don't try to cross-build.

# We don't build coreutils without MULTICALL=y
! test -e target/debug/coreutils
# build (host)
Expand Down Expand Up @@ -274,8 +269,6 @@ jobs:
test_busybox:
name: Tests/BusyBox test suite
runs-on: ${{ matrix.job.os }}
env:
CARGO_INCREMENTAL: 0
strategy:
fail-fast: false
matrix:
Expand Down Expand Up @@ -360,8 +353,6 @@ jobs:
test_toybox:
name: Tests/Toybox test suite
runs-on: ${{ matrix.job.os }}
env:
CARGO_INCREMENTAL: 0
strategy:
fail-fast: false
matrix:
Expand All @@ -379,9 +370,6 @@ jobs:
- uses: actions/checkout@v6
with:
persist-credentials: false
- uses: dtolnay/rust-toolchain@master
with:
toolchain: ${{ env.RUST_MIN_SRV }}
- uses: Swatinem/rust-cache@v2
- name: Run sccache-cache
id: sccache-setup
Expand Down
Loading