uucore: reject non-regular and oversized locale files#11234
Open
mattsu2020 wants to merge 1 commit intouutils:mainfrom
Open
uucore: reject non-regular and oversized locale files#11234mattsu2020 wants to merge 1 commit intouutils:mainfrom
mattsu2020 wants to merge 1 commit intouutils:mainfrom
Conversation
|
GNU testsuite comparison: |
Contributor
|
i found this overkill for something that will never happen in real life |
Contributor
|
How about loading *.ftl to stack with sizes determined at build.rs for perf? |
Contributor
|
This does not happen for proper packages. So I think we can just remove localization feature from https://github.com/uutils/coreutils/releases by |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix a localization startup issue where
.ftlfiles were read withfs::read_to_string()without validating the target file type or size first.If a locale file is symlinked to
/dev/zero, startup can keep reading indefinitely until the process is killed by OOM. This affects utilities liketruebecause localization is initialized before the utility runs.What changed
.ftlfilesTests
Added coverage for:
/dev/zeroResult
Utilities no longer risk unbounded memory growth during localization setup when locale files point to special files such as
/dev/zero.issue
#11230