test(cksum): regression test for write errors to /dev/full#10978
Open
naoNao89 wants to merge 1 commit intouutils:mainfrom
Open
test(cksum): regression test for write errors to /dev/full#10978naoNao89 wants to merge 1 commit intouutils:mainfrom
naoNao89 wants to merge 1 commit intouutils:mainfrom
Conversation
|
GNU testsuite comparison: |
Contributor
|
As per #10536, any functions that now take |
xtqqczze
reviewed
Feb 16, 2026
naoNao89
force-pushed
the
fix-cksum-stdout-panic
branch
from
49f72b6 to
8624081
Compare
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
xtqqczze
approved these changes
Feb 17, 2026
Contributor
xtqqczze
left a comment
xtqqczze
left a comment
There was a problem hiding this comment.
nit: update comments like "Print the filename" to "Write the filename"
|
GNU testsuite comparison: |
Contributor
|
Fixed by different PR |
Contributor
|
Indeed, fixed by #12099. It may still be worthwhile merging the regression test from this PR. |
Adds a Linux-only regression test that verifies cksum exits with code 1 (rather than panicking) when stdout is /dev/full. Refs uutils#10947 (fixed by uutils#12099).
naoNao89
force-pushed
the
fix-cksum-stdout-panic
branch
from
0a6366a to
68e777d
Compare
naoNao89
changed the title
Contributor
Author
|
tks for the feedback. Covert this PR down to just the regression test since #12099 already landed the fix |
|
GNU testsuite comparison: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a Linux-only regression test verifying that
cksumexits with code 1 (instead of panicking) when stdout is/dev/full.Refs #10947, which has been fixed by #12099. Per @xtqqczze's suggestion in this comment, this PR has been reduced to the regression test only; the original implementation has been dropped.