Fixed tail --follow=name continuing to tail a symlink target, unlike GNU tail. Closes #10328 #10397
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
GNU testsuite comparison: |
Merging this PR will improve performance by 4.4%
Performance Changes
Comparing 
Footnotes
|
sylvestre
reviewed
Jan 20, 2026
src/uu/tail/src/follow/watch.rs
Outdated
| path.to_owned() | ||
| }; | ||
| let metadata = path.metadata().ok(); | ||
| let is_symlink = path |
Contributor
There was a problem hiding this comment.
please dedup the declaration (see files:.rs:215)
sylvestre
reviewed
Jan 20, 2026
src/uu/tail/src/follow/watch.rs
Outdated
| EventKind::Modify(ModifyKind::Metadata(MetadataKind::Any | MetadataKind::WriteTime) | ModifyKind::Data(DataChange::Any) | ModifyKind::Name(RenameMode::To)) | | ||
| EventKind::Create(CreateKind::File | CreateKind::Folder | CreateKind::Any) => { | ||
| if let Ok(new_md) = event_path.metadata() { | ||
| let new_is_symlink = event_path |
sylvestre
reviewed
Jan 20, 2026
Comment on lines
316
to
317
| if self.follow_name() && !pd.is_symlink && new_is_symlink { | ||
| if pd.reader.is_some() { |
Contributor
There was a problem hiding this comment.
please add comments to describe why we could be here
sylvestre
reviewed
Jan 20, 2026
| .symlink_metadata() | ||
| .is_ok_and(|meta| meta.file_type().is_symlink()); | ||
| if !pd.is_symlink && new_is_symlink { | ||
| show_error!( |
Contributor
There was a problem hiding this comment.
see that it is duplicated from above
Contributor
Author
|
@sylvestre fixed, how's that? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed tail --follow=name continuing to tail a symlink target, unlike GNU tail. Closes #10328. Also added a regression test for it. Note that I had a translation app do the French string, as I wasn't entirely sure on the protocol for PRs introducing new strings. Let me know if I need to change anything!