Skip to content

Conversation

@FidelSch
Copy link
Contributor

This allows processing input that does not contain newlines. Adresses #10227

This allows processing input that does not contain newlines.
@github-actions
Copy link

GNU testsuite comparison:

GNU test failed: tests/fold/fold-characters. tests/fold/fold-characters is passing on 'main'. Maybe you have to rebase?

@codspeed-hq
Copy link

codspeed-hq bot commented Jan 20, 2026

CodSpeed Performance Report

Merging this PR will degrade performance by 5.28%

Comparing FidelSch:fold-pipe-flush (a0a006f) with main (cbbff30)

Summary

⚡ 1 improved benchmark
❌ 1 regressed benchmark
✅ 140 untouched benchmarks
⏩ 180 skipped benchmarks1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation sort_ascii_utf8_locale 18.1 ms 17.5 ms +3.84%
Simulation fold_many_lines[100000] 80.4 ms 84.9 ms -5.28%

Footnotes

  1. 180 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

};

match std::str::from_utf8(&buffer) {
Ok(s) => process_utf8_line(s, &mut ctx)?,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Theres a bug here where non-utf8 characters at the end of a chunk can be split in two so a single multi byte character will be split into multiple characters.

@github-actions
Copy link

GNU testsuite comparison:

Skip an intermittent issue tests/tty/tty-eof (fails in this run but passes in the 'main' branch)

@github-actions
Copy link

GNU testsuite comparison:

Skipping an intermittent issue tests/shuf/shuf-reservoir (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/sort/sort-stale-thread-mem (passes in this run but fails in the 'main' branch)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants