-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
benchmarks: prepare args outside benchmark #10388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
GNU testsuite comparison: |
CodSpeed Performance ReportMerging this PR will degrade performance by 26.29%Comparing Summary
Performance Changes
Footnotes
|
|
@sylvestre Please could you confirm whether these changes are viable to apply in full? |
|
i guess ? :) |
|
Need to refactor to handle the following case: coreutils/src/uu/cp/benches/cp_bench.rs Lines 27 to 33 in 456252f
|
75ad901 to
1936e7b
Compare
|
Should we wait working about #10486 until your PR was merged? |
Currently, we construct
uucore::Argswithin the measured section of benchmarks. That adds allocation and conversion overhead and will skew the results.