Skip to content

Conversation

@oech3
Copy link
Contributor

@oech3 oech3 commented Jan 19, 2026

No description provided.

@github-actions
Copy link

GNU testsuite comparison:

Skipping an intermittent issue tests/shuf/shuf-reservoir (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/sort/sort-stale-thread-mem (passes in this run but fails in the 'main' branch)

@codspeed-hq
Copy link

codspeed-hq bot commented Jan 19, 2026

CodSpeed Performance Report

Merging this PR will improve performance by 4.63%

Comparing oech3:patch-10 (c0f67c6) with main (43fcff8)

Summary

⚡ 2 improved benchmarks
✅ 280 untouched benchmarks
⏩ 38 skipped benchmarks1

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Memory sort_key_field[500000] 32.8 MB 31.4 MB +4.63%
Memory sort_numeric[500000] 48.7 MB 47.3 MB +3.06%

Footnotes

  1. 38 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@oech3 oech3 force-pushed the patch-10 branch 3 times, most recently from 01db512 to 3b00671 Compare January 20, 2026 16:59
@oech3
Copy link
Contributor Author

oech3 commented Jan 20, 2026

Are symlinks not necessary?

@sylvestre
Copy link
Contributor

Did you evaluate the perf win? Thanks

@github-actions
Copy link

GNU testsuite comparison:

Skip an intermittent issue tests/tty/tty-eof (fails in this run but passes in the 'main' branch)

@oech3
Copy link
Contributor Author

oech3 commented Jan 30, 2026

About -30 s (with debug build)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants