Support duplicate handling for Appwrite imports#205
Conversation
Greptile SummaryThis PR adds skip and overwrite duplicate-handling modes to the Appwrite-to-Appwrite migration destination, propagates
Confidence Score: 4/5Safe to merge for skip mode; the overwrite path for function and site deployments deletes before re-uploading, which is riskier than the stated intent and should be confirmed or corrected before enabling overwrite mode in production. The deployment overwrite branches call
Important Files Changed
Prompt To Fix All With AIFix the following 1 code review issue. Work through them one at a time, proposing concise fixes.
---
### Issue 1 of 1
src/Migration/Destinations/Appwrite.php:2810-2812
**Deployment overwrite contradicts stated design**
The PR's Review Notes explicitly say "existing function/site deployments are skipped instead of deleted and recreated," yet this code deletes the deployment and re-uploads it in `OnDuplicate::Overwrite` mode. If the intent was the conservative skip described in the notes, the overwrite branch should set `STATUS_SKIPPED` and return early — mirroring the `OnDuplicate::Skip` branch above — rather than calling `deleteDeployment`. The same mismatch exists in `importSiteDeploymentWithDuplicateCheck` (line 3702).
Reviews (7): Last reviewed commit: "Merge main into skip override migration" | Re-trigger Greptile |
Summary
Validation
Review Notes