In case of an case sensitive file system, probe for other cases in the maven resolver - #2845
Open
DavyLandman wants to merge 1 commit into
Open
In case of an case sensitive file system, probe for other cases in the maven resolver#2845DavyLandman wants to merge 1 commit into
DavyLandman wants to merge 1 commit into
Conversation
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2845 +/- ##
=======================================
Coverage 45% 45%
- Complexity 6718 6726 +8
=======================================
Files 841 841
Lines 67018 67056 +38
Branches 10012 10021 +9
=======================================
+ Hits 30769 30799 +30
- Misses 33863 33870 +7
- Partials 2386 2387 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
jurgenvinju
reviewed
Aug 15, 2026
| /** | ||
| * recursively probe file system to find candidate matches for the full file name in a different casing | ||
| */ | ||
| private @Nullable ISourceLocation pathMatcher(ISourceLocation root, String subPart) throws IOException { |
Member
There was a problem hiding this comment.
Since listAllMainArtifacts contains the same logic and file discovery process, could we reuse that and normalize the String[] until we find a match. Or even factor out its Stream<String> and normalize and find the first match?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing a part of #2842