Unify VFS interfaces#2641
Conversation
…IResolverRegistry
… a port during start-up
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2641 +/- ##
========================================
- Coverage 46% 46% -1%
- Complexity 6719 6726 +7
========================================
Files 794 829 +35
Lines 65937 66586 +649
Branches 9889 9956 +67
========================================
+ Hits 30759 30781 +22
- Misses 32798 33428 +630
+ Partials 2380 2377 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
toinehartman
left a comment
toinehartman
left a comment
There was a problem hiding this comment.
All of this (and the companion PR usethesource/rascal-language-servers#967) look like a nice unification and clean-up of interfaces.
DavyLandman
left a comment
DavyLandman
left a comment
There was a problem hiding this comment.
It's making progress, but it's not there yet.
|
|
|
||
| import io.usethesource.vallang.ISourceLocation; | ||
|
|
||
| public interface JsonRpcRequest { |
There was a problem hiding this comment.
Can we give this a more specific name? like JsonRpcRequest does not explain why it has transformLocations on there?
| @Override | ||
| public boolean supportsCopy() { | ||
| try { | ||
| return call(getRemote()::supportsCopy).getValue(); | ||
| } catch (IOException e) { | ||
| return false; | ||
| } | ||
| } |
There was a problem hiding this comment.
I think remote file systems should always support local copy. so we should return true. and not have this as part of the rpc interface.
same for rename.
|
3 participants
Closes #2701